Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1282776

Re: Asterisk deadlocks since Kernel 4.1

Show all headers | View raw

> Am 02.12.2015 um 12:40 schrieb Hannes Frederic Sowa <hannes@stressinduktion.org>:
> 
> Hello Stefan,
> 
> Stefan Priebe - Profihost AG <s.priebe@profihost.ag> writes:
> 
> 
>> here are the results.
>> 
>> It works with 4.1.
>> It works with 4.2.
>> It does not work with 4.1.13.
>> 
>> git bisect tells me it stopped working after those two commits were applied:
>> 
>> commit d48623677191e0f035d7afd344f92cf880b01f8e
>> Author: Herbert Xu <herbert@gondor.apana.org.au>
>> Date:   Tue Sep 22 11:38:56 2015 +0800
>> 
>>    netlink: Replace rhash_portid with bound
>> 
>> commit 4e27762417669cb459971635be550eb7b5598286
>> Author: Herbert Xu <herbert@gondor.apana.org.au>
>> Date:   Fri Sep 18 19:16:50 2015 +0800
>> 
>>    netlink: Fix autobind race condition that leads to zero port ID
> 
> Cool, thanks a lot. Does this patch make a difference?
> 
> diff --git a/net/netlink/af_netlink.c b/net/netlink/af_netlink.c
> index 59651af..278e94c 100644
> --- a/net/netlink/af_netlink.c
> +++ b/net/netlink/af_netlink.c
> @@ -1137,7 +1137,7 @@ static int netlink_insert(struct sock *sk, u32 portid)
> 
>    /* We need to ensure that the socket is hashed and visible. */
>    smp_wmb();
> -    nlk_sk(sk)->bound = portid;
> +    nlk_sk(sk)->bound = true;
> 
> err:
>    release_sock(sk);

Will try that soon but already started another test. I reverted all netlink patches from 4.1.13 back to 4.1 and applied all netlink patches from 4.1 up to 4.3.

Greets,
Stefan--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: Asterisk deadlocks since Kernel 4.1 Stefan Priebe - Profihost AG <s.priebe@profihost.ag> - 2015-12-02 10:50 +0100
  Re: Asterisk deadlocks since Kernel 4.1 Hannes Frederic Sowa <hannes@stressinduktion.org> - 2015-12-02 12:50 +0100
    Re: Asterisk deadlocks since Kernel 4.1 Philipp Hahn <pmhahn@pmhahn.de> - 2015-12-02 19:00 +0100
    Re: Asterisk deadlocks since Kernel 4.1 Stefan Priebe - Profihost AG <s.priebe@profihost.ag> - 2015-12-03 09:30 +0100
    Re: Asterisk deadlocks since Kernel 4.1 Stefan Priebe <s.priebe@profihost.ag> - 2015-12-04 19:30 +0100
      Re: Asterisk deadlocks since Kernel 4.1 Herbert Xu <herbert@gondor.apana.org.au> - 2015-12-05 02:10 +0100
        Re: Asterisk deadlocks since Kernel 4.1 Stefan Priebe <s.priebe@profihost.ag> - 2015-12-06 22:00 +0100
          Re: Asterisk deadlocks since Kernel 4.1 Herbert Xu <herbert@gondor.apana.org.au> - 2015-12-07 02:30 +0100
            Re: Asterisk deadlocks since Kernel 4.1 Stefan Priebe - Profihost AG <s.priebe@profihost.ag> - 2015-12-07 08:00 +0100
              netlink: Add missing goto statement to netlink_insert Herbert Xu <herbert@gondor.apana.org.au> - 2015-12-08 07:20 +0100
                Re: netlink: Add missing goto statement to netlink_insert David Miller <davem@davemloft.net> - 2015-12-08 17:30 +0100
                Re: netlink: Add missing goto statement to netlink_insert Greg KH <greg@kroah.com> - 2015-12-09 04:40 +0100
          Re: Asterisk deadlocks since Kernel 4.1 Philipp Hahn <pmhahn@pmhahn.de> - 2015-12-07 08:50 +0100
    Re: Asterisk deadlocks since Kernel 4.1 Philipp Matthias Hahn <pmhahn@pmhahn.de> - 2015-12-05 15:20 +0100
      Re: Asterisk deadlocks since Kernel 4.1 Stefan Priebe <s.priebe@profihost.ag> - 2015-12-05 16:40 +0100
  Re: Asterisk deadlocks since Kernel 4.1 Philipp Hahn <pmhahn@pmhahn.de> - 2015-12-02 19:00 +0100
    Re: Asterisk deadlocks since Kernel 4.1 Hannes Frederic Sowa <hannes@stressinduktion.org> - 2015-12-02 19:30 +0100

csiph-web