Re: [PATCH 2/2] pinctrl: single: remove misuse of IRQF_NO_SUSPEND flag

Path	csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod
From	Tony Lindgren <tony@atomide.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/2] pinctrl: single: remove misuse of IRQF_NO_SUSPEND flag
Date	Fri, 04 Dec 2015 18:20:02 +0100
Message-ID	<qC2bw-5CT-23@gated-at.bofh.it> (permalink)
References	<qzv0m-5QM-5@gated-at.bofh.it> <qzv0m-5QM-3@gated-at.bofh.it> <qATMZ-2eD-1@gated-at.bofh.it> <qBGE3-cG-27@gated-at.bofh.it> <qBHgK-qe-5@gated-at.bofh.it> <qBJVg-293-5@gated-at.bofh.it> <qC0Mq-4A2-19@gated-at.bofh.it> <qC1ft-50Q-33@gated-at.bofh.it>
X-Original-To	Sudeep Holla <sudeep.holla@arm.com>
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	Mutt/1.5.24 (2015-08-30)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	44
Organization	linux.* mail to news gateway
X-Original-Cc	Linus Walleij <linus.walleij@linaro.org>, Grygorii Strashko <grygorii.strashko@ti.com>, "linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, linux-omap@vger.kernel.org
X-Original-Date	Fri, 4 Dec 2015 09:10:50 -0800
X-Original-Message-ID	<20151204171050.GM23396@atomide.com>
X-Original-References	<1448644860-29323-1-git-send-email-sudeep.holla@arm.com> <1448644860-29323-2-git-send-email-sudeep.holla@arm.com> <CACRpkdYy1fPAm5r0GxXxzgZA7RsqJ6ZtPtNzd1bzrfkME_j09g@mail.gmail.com> <20151203181337.GV23396@atomide.com> <566090FC.1020502@arm.com> <20151203214013.GB23396@atomide.com> <20151204154031.GG23396@atomide.com> <5661BC21.2050802@arm.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1284062

Show key headers only | View raw

* Sudeep Holla <sudeep.holla@arm.com> [151204 08:16]:
> Hi Tony,
> 
> On 04/12/15 15:40, Tony Lindgren wrote:
> >* Tony Lindgren <tony@atomide.com> [151203 13:41]:
> >>* Sudeep Holla <sudeep.holla@arm.com> [151203 11:00]:
> >>>
> >>>I have added irq_set_irq_wake(pcs_soc->irq, state) in pcs_irq_set_wake
> >>>which ensures it's marked for wakeup.
> >>
> >>Hmm well see the error I pasted in this thread, maybe that provides
> >>more clues.
> >
> >The irq_set_irq_wake(pcs_soc->irq, state) in pcs_irq_set_wake does not
> >look right to me as pcs_irq_set_wake toggles the irq_wake for each pin
> >separately, not for the whole controller.
> >
> 
> After thinking more about it we need some way to tell IRQ core that
> pcs_soc->irq is wakeup capable. Is that going to happen automatically
> via dev_pm_set_dedicated_wake_irq as you mentioned earlier ?
> 
> >I think all that can be left out with the snipped from Grygorii, and maybe
> >also the lock_class_key changes.
> >
> 
> If we not calling irq_set_irq_wake(pcs_soc->irq) in pcs_irq_set_wake, do
> you see possibility of lockdep recursion in any other paths.
> 
> Otherwise we don't need this if we remove irq_set_irq_wake(pcs_soc->irq)
> from pcs_irq_set_wake

I think Grygorii is right here and this is correct as it's a counter
once the other issues are sorted out and we have figured out what all
needs to be patched together.

Regards,

Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH 2/2] pinctrl: single: remove misuse of IRQF_NO_SUSPEND flag Linus Walleij <linus.walleij@linaro.org> - 2015-12-01 15:10 +0100
  Re: [PATCH 2/2] pinctrl: single: remove misuse of IRQF_NO_SUSPEND  flag Tony Lindgren <tony@atomide.com> - 2015-12-03 19:20 +0100
    Re: [PATCH 2/2] pinctrl: single: remove misuse of IRQF_NO_SUSPEND  flag Grygorii Strashko <grygorii.strashko@ti.com> - 2015-12-03 19:40 +0100
      Re: [PATCH 2/2] pinctrl: single: remove misuse of IRQF_NO_SUSPEND  flag Tony Lindgren <tony@atomide.com> - 2015-12-03 22:40 +0100
        Re: [PATCH 2/2] pinctrl: single: remove misuse of IRQF_NO_SUSPEND  flag Grygorii Strashko <grygorii.strashko@ti.com> - 2015-12-04 11:50 +0100
          Re: [PATCH 2/2] pinctrl: single: remove misuse of IRQF_NO_SUSPEND  flag Sudeep Holla <sudeep.holla@arm.com> - 2015-12-04 12:00 +0100
            Re: [PATCH 2/2] pinctrl: single: remove misuse of IRQF_NO_SUSPEND  flag Grygorii Strashko <grygorii.strashko@ti.com> - 2015-12-04 12:20 +0100
              Re: [PATCH 2/2] pinctrl: single: remove misuse of IRQF_NO_SUSPEND  flag Sudeep Holla <sudeep.holla@arm.com> - 2015-12-04 12:30 +0100
          Re: [PATCH 2/2] pinctrl: single: remove misuse of IRQF_NO_SUSPEND  flag Tony Lindgren <tony@atomide.com> - 2015-12-04 16:40 +0100
            Re: [PATCH 2/2] pinctrl: single: remove misuse of IRQF_NO_SUSPEND  flag Grygorii Strashko <grygorii.strashko@ti.com> - 2015-12-04 17:00 +0100
              Re: [PATCH 2/2] pinctrl: single: remove misuse of IRQF_NO_SUSPEND  flag Sudeep Holla <sudeep.holla@arm.com> - 2015-12-04 17:20 +0100
                Re: [PATCH 2/2] pinctrl: single: remove misuse of IRQF_NO_SUSPEND  flag Grygorii Strashko <grygorii.strashko@ti.com> - 2015-12-04 17:40 +0100
                Re: [PATCH 2/2] pinctrl: single: remove misuse of IRQF_NO_SUSPEND  flag Tony Lindgren <tony@atomide.com> - 2015-12-04 18:10 +0100
              Re: [PATCH 2/2] pinctrl: single: remove misuse of IRQF_NO_SUSPEND  flag Tony Lindgren <tony@atomide.com> - 2015-12-04 18:10 +0100
    Re: [PATCH 2/2] pinctrl: single: remove misuse of IRQF_NO_SUSPEND  flag Sudeep Holla <sudeep.holla@arm.com> - 2015-12-03 20:00 +0100
      Re: [PATCH 2/2] pinctrl: single: remove misuse of IRQF_NO_SUSPEND  flag Tony Lindgren <tony@atomide.com> - 2015-12-03 22:50 +0100
        Re: [PATCH 2/2] pinctrl: single: remove misuse of IRQF_NO_SUSPEND  flag Tony Lindgren <tony@atomide.com> - 2015-12-04 16:50 +0100
          Re: [PATCH 2/2] pinctrl: single: remove misuse of IRQF_NO_SUSPEND  flag Sudeep Holla <sudeep.holla@arm.com> - 2015-12-04 16:50 +0100
            Re: [PATCH 2/2] pinctrl: single: remove misuse of IRQF_NO_SUSPEND  flag Grygorii Strashko <grygorii.strashko@ti.com> - 2015-12-04 17:30 +0100
              Re: [PATCH 2/2] pinctrl: single: remove misuse of IRQF_NO_SUSPEND  flag Sudeep Holla <sudeep.holla@arm.com> - 2015-12-04 17:30 +0100
                Re: [PATCH 2/2] pinctrl: single: remove misuse of IRQF_NO_SUSPEND  flag Tony Lindgren <tony@atomide.com> - 2015-12-04 18:10 +0100
          Re: [PATCH 2/2] pinctrl: single: remove misuse of IRQF_NO_SUSPEND  flag Sudeep Holla <sudeep.holla@arm.com> - 2015-12-04 17:20 +0100
            Re: [PATCH 2/2] pinctrl: single: remove misuse of IRQF_NO_SUSPEND  flag Tony Lindgren <tony@atomide.com> - 2015-12-04 18:20 +0100

csiph-web