Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1283980

Re: [PATCH 2/2] pinctrl: single: remove misuse of IRQF_NO_SUSPEND flag

From Sudeep Holla <sudeep.holla@arm.com>
Newsgroups linux.kernel
Subject Re: [PATCH 2/2] pinctrl: single: remove misuse of IRQF_NO_SUSPEND flag
Date 2015-12-04 17:20 +0100
Message-ID <qC1ft-50Q-33@gated-at.bofh.it> (permalink)
References (2 earlier) <qATMZ-2eD-1@gated-at.bofh.it> <qBGE3-cG-27@gated-at.bofh.it> <qBHgK-qe-5@gated-at.bofh.it> <qBJVg-293-5@gated-at.bofh.it> <qC0Mq-4A2-19@gated-at.bofh.it>
Organization ARM

Show all headers | View raw

Hi Tony,

On 04/12/15 15:40, Tony Lindgren wrote:
> * Tony Lindgren <tony@atomide.com> [151203 13:41]:
>> * Sudeep Holla <sudeep.holla@arm.com> [151203 11:00]:
>>>
>>> I have added irq_set_irq_wake(pcs_soc->irq, state) in pcs_irq_set_wake
>>> which ensures it's marked for wakeup.
>>
>> Hmm well see the error I pasted in this thread, maybe that provides
>> more clues.
>
> The irq_set_irq_wake(pcs_soc->irq, state) in pcs_irq_set_wake does not
> look right to me as pcs_irq_set_wake toggles the irq_wake for each pin
> separately, not for the whole controller.
>

After thinking more about it we need some way to tell IRQ core that
pcs_soc->irq is wakeup capable. Is that going to happen automatically
via dev_pm_set_dedicated_wake_irq as you mentioned earlier ?

> I think all that can be left out with the snipped from Grygorii, and maybe
> also the lock_class_key changes.
>

If we not calling irq_set_irq_wake(pcs_soc->irq) in pcs_irq_set_wake, do
you see possibility of lockdep recursion in any other paths.

Otherwise we don't need this if we remove irq_set_irq_wake(pcs_soc->irq)
from pcs_irq_set_wake

-- 
Regards,
Sudeep
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH 2/2] pinctrl: single: remove misuse of IRQF_NO_SUSPEND flag Linus Walleij <linus.walleij@linaro.org> - 2015-12-01 15:10 +0100
  Re: [PATCH 2/2] pinctrl: single: remove misuse of IRQF_NO_SUSPEND  flag Tony Lindgren <tony@atomide.com> - 2015-12-03 19:20 +0100
    Re: [PATCH 2/2] pinctrl: single: remove misuse of IRQF_NO_SUSPEND  flag Grygorii Strashko <grygorii.strashko@ti.com> - 2015-12-03 19:40 +0100
      Re: [PATCH 2/2] pinctrl: single: remove misuse of IRQF_NO_SUSPEND  flag Tony Lindgren <tony@atomide.com> - 2015-12-03 22:40 +0100
        Re: [PATCH 2/2] pinctrl: single: remove misuse of IRQF_NO_SUSPEND  flag Grygorii Strashko <grygorii.strashko@ti.com> - 2015-12-04 11:50 +0100
          Re: [PATCH 2/2] pinctrl: single: remove misuse of IRQF_NO_SUSPEND  flag Sudeep Holla <sudeep.holla@arm.com> - 2015-12-04 12:00 +0100
            Re: [PATCH 2/2] pinctrl: single: remove misuse of IRQF_NO_SUSPEND  flag Grygorii Strashko <grygorii.strashko@ti.com> - 2015-12-04 12:20 +0100
              Re: [PATCH 2/2] pinctrl: single: remove misuse of IRQF_NO_SUSPEND  flag Sudeep Holla <sudeep.holla@arm.com> - 2015-12-04 12:30 +0100
          Re: [PATCH 2/2] pinctrl: single: remove misuse of IRQF_NO_SUSPEND  flag Tony Lindgren <tony@atomide.com> - 2015-12-04 16:40 +0100
            Re: [PATCH 2/2] pinctrl: single: remove misuse of IRQF_NO_SUSPEND  flag Grygorii Strashko <grygorii.strashko@ti.com> - 2015-12-04 17:00 +0100
              Re: [PATCH 2/2] pinctrl: single: remove misuse of IRQF_NO_SUSPEND  flag Sudeep Holla <sudeep.holla@arm.com> - 2015-12-04 17:20 +0100
                Re: [PATCH 2/2] pinctrl: single: remove misuse of IRQF_NO_SUSPEND  flag Grygorii Strashko <grygorii.strashko@ti.com> - 2015-12-04 17:40 +0100
                Re: [PATCH 2/2] pinctrl: single: remove misuse of IRQF_NO_SUSPEND  flag Tony Lindgren <tony@atomide.com> - 2015-12-04 18:10 +0100
              Re: [PATCH 2/2] pinctrl: single: remove misuse of IRQF_NO_SUSPEND  flag Tony Lindgren <tony@atomide.com> - 2015-12-04 18:10 +0100
    Re: [PATCH 2/2] pinctrl: single: remove misuse of IRQF_NO_SUSPEND  flag Sudeep Holla <sudeep.holla@arm.com> - 2015-12-03 20:00 +0100
      Re: [PATCH 2/2] pinctrl: single: remove misuse of IRQF_NO_SUSPEND  flag Tony Lindgren <tony@atomide.com> - 2015-12-03 22:50 +0100
        Re: [PATCH 2/2] pinctrl: single: remove misuse of IRQF_NO_SUSPEND  flag Tony Lindgren <tony@atomide.com> - 2015-12-04 16:50 +0100
          Re: [PATCH 2/2] pinctrl: single: remove misuse of IRQF_NO_SUSPEND  flag Sudeep Holla <sudeep.holla@arm.com> - 2015-12-04 16:50 +0100
            Re: [PATCH 2/2] pinctrl: single: remove misuse of IRQF_NO_SUSPEND  flag Grygorii Strashko <grygorii.strashko@ti.com> - 2015-12-04 17:30 +0100
              Re: [PATCH 2/2] pinctrl: single: remove misuse of IRQF_NO_SUSPEND  flag Sudeep Holla <sudeep.holla@arm.com> - 2015-12-04 17:30 +0100
                Re: [PATCH 2/2] pinctrl: single: remove misuse of IRQF_NO_SUSPEND  flag Tony Lindgren <tony@atomide.com> - 2015-12-04 18:10 +0100
          Re: [PATCH 2/2] pinctrl: single: remove misuse of IRQF_NO_SUSPEND  flag Sudeep Holla <sudeep.holla@arm.com> - 2015-12-04 17:20 +0100
            Re: [PATCH 2/2] pinctrl: single: remove misuse of IRQF_NO_SUSPEND  flag Tony Lindgren <tony@atomide.com> - 2015-12-04 18:20 +0100

csiph-web