Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1283944
| From | Boris Ostrovsky <boris.ostrovsky@oracle.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [Xen-devel] [PATCHv1] x86: rtc_cmos platform device requires legacy irqs |
| Date | 2015-12-04 16:40 +0100 |
| Message-ID | <qC0CK-4wp-33@gated-at.bofh.it> (permalink) |
| References | <qBzCy-3N9-25@gated-at.bofh.it> <qBZdE-3Gv-13@gated-at.bofh.it> <qC0t4-4sT-11@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 12/04/2015 10:24 AM, David Vrabel wrote: > On 04/12/15 14:06, David Vrabel wrote: >> On 03/12/15 10:43, David Vrabel wrote: >>> Adding the rtc platform device when there are no legacy irqs (no >>> legacy PIC) causes a conflict with other devices that end up using the >>> same irq number. >> An alternative is to remove the rtc_cmos platform device in Xen PV >> guests. >> >> Any preference on how this regression should be fixed? >> >> David >> >> 8<-------------------------- >> x86: Xen PV guests don't have the rtc_cmos platform device >> > [...] >> --- a/arch/x86/kernel/rtc.c >> +++ b/arch/x86/kernel/rtc.c >> @@ -200,6 +200,9 @@ static __init int add_rtc_cmos(void) >> } >> #endif >> >> + if (xen_pv_domain()) >> + return -ENODEV; >> + > Note there's a missing include that breaks !XEN builds. We could also use paravirt_enable() here which will probably cover HVMlite case as well. (Until we start turning on and off various HVMlite features). Don't know how it will affect lguest (which so far is the only other paravirt-enabled guest). -boris -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCHv1] x86: rtc_cmos platform device requires legacy irqs David Vrabel <david.vrabel@citrix.com> - 2015-12-03 11:50 +0100
Re: [Xen-devel] [PATCHv1] x86: rtc_cmos platform device requires legacy irqs Vitaly Kuznetsov <vkuznets@redhat.com> - 2015-12-03 12:30 +0100
Re: [Xen-devel] [PATCHv1] x86: rtc_cmos platform device requires legacy irqs David Vrabel <david.vrabel@citrix.com> - 2015-12-03 16:10 +0100
Re: [Xen-devel] [PATCHv1] x86: rtc_cmos platform device requires legacy irqs David Vrabel <david.vrabel@citrix.com> - 2015-12-04 15:10 +0100
Re: [Xen-devel] [PATCHv1] x86: rtc_cmos platform device requires legacy irqs David Vrabel <david.vrabel@citrix.com> - 2015-12-04 16:30 +0100
Re: [Xen-devel] [PATCHv1] x86: rtc_cmos platform device requires legacy irqs Boris Ostrovsky <boris.ostrovsky@oracle.com> - 2015-12-04 16:40 +0100
Re: [Xen-devel] [PATCHv1] x86: rtc_cmos platform device requires legacy irqs Vitaly Kuznetsov <vkuznets@redhat.com> - 2015-12-04 17:00 +0100
Re: [Xen-devel] [PATCHv1] x86: rtc_cmos platform device requires legacy irqs Boris Ostrovsky <boris.ostrovsky@oracle.com> - 2015-12-04 17:20 +0100
Re: [Xen-devel] [PATCHv1] x86: rtc_cmos platform device requires legacy irqs Thomas Gleixner <tglx@linutronix.de> - 2015-12-08 22:10 +0100
Re: [Xen-devel] [PATCHv1] x86: rtc_cmos platform device requires legacy irqs Boris Ostrovsky <boris.ostrovsky@oracle.com> - 2015-12-08 22:20 +0100
Re: [Xen-devel] [PATCHv1] x86: rtc_cmos platform device requires legacy irqs Thomas Gleixner <tglx@linutronix.de> - 2015-12-08 22:30 +0100
csiph-web