Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1283835

Re: [Xen-devel] [PATCHv1] x86: rtc_cmos platform device requires legacy irqs

Show all headers | View raw

On 03/12/15 10:43, David Vrabel wrote:
> Adding the rtc platform device when there are no legacy irqs (no
> legacy PIC) causes a conflict with other devices that end up using the
> same irq number.

An alternative is to remove the rtc_cmos platform device in Xen PV
guests.

Any preference on how this regression should be fixed?

David

8<--------------------------
x86: Xen PV guests don't have the rtc_cmos platform device

Adding the rtc platform device in a Xen PV guests causes an IRQ
conflict because these guests do not have a legacy PIC.

In a single VCPU Xen PV guest we should have:

/proc/interrupts:
           CPU0
  0:       4934  xen-percpu-virq      timer0
  1:          0  xen-percpu-ipi       spinlock0
  2:          0  xen-percpu-ipi       resched0
  3:          0  xen-percpu-ipi       callfunc0
  4:          0  xen-percpu-virq      debug0
  5:          0  xen-percpu-ipi       callfuncsingle0
  6:          0  xen-percpu-ipi       irqwork0
  7:        321   xen-dyn-event     xenbus
  8:         90   xen-dyn-event     hvc_console
  ...

But hvc_console cannot get its interrupt because it is already in use
by rtc0 and the console does not work.

  genirq: Flags mismatch irq 8. 00000000 (hvc_console) vs. 00000000 (rtc0)

So don't add the rtc_cmos device in Xen PV guests.

Reported-by: Sander Eikelenboom <linux@eikelenboom.it>
Signed-off-by: David Vrabel <david.vrabel@citrix.com>
Tested-by: Sander Eikelenboom <linux@eikelenboom.it>
---
 arch/x86/kernel/rtc.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/arch/x86/kernel/rtc.c b/arch/x86/kernel/rtc.c
index cd96852..7b190b8 100644
--- a/arch/x86/kernel/rtc.c
+++ b/arch/x86/kernel/rtc.c
@@ -200,6 +200,9 @@ static __init int add_rtc_cmos(void)
 	}
 #endif
 
+	if (xen_pv_domain())
+		return -ENODEV;
+
 	platform_device_register(&rtc_device);
 	dev_info(&rtc_device.dev,
 		 "registered platform RTC device (no PNP device found)\n");
-- 
2.1.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCHv1] x86: rtc_cmos platform device requires legacy irqs David Vrabel <david.vrabel@citrix.com> - 2015-12-03 11:50 +0100
  Re: [Xen-devel] [PATCHv1] x86: rtc_cmos platform device requires legacy irqs Vitaly Kuznetsov <vkuznets@redhat.com> - 2015-12-03 12:30 +0100
    Re: [Xen-devel] [PATCHv1] x86: rtc_cmos platform device requires  legacy irqs David Vrabel <david.vrabel@citrix.com> - 2015-12-03 16:10 +0100
  Re: [Xen-devel] [PATCHv1] x86: rtc_cmos platform device requires  legacy irqs David Vrabel <david.vrabel@citrix.com> - 2015-12-04 15:10 +0100
    Re: [Xen-devel] [PATCHv1] x86: rtc_cmos platform device requires  legacy irqs David Vrabel <david.vrabel@citrix.com> - 2015-12-04 16:30 +0100
      Re: [Xen-devel] [PATCHv1] x86: rtc_cmos platform device requires  legacy irqs Boris Ostrovsky <boris.ostrovsky@oracle.com> - 2015-12-04 16:40 +0100
        Re: [Xen-devel] [PATCHv1] x86: rtc_cmos platform device requires legacy irqs Vitaly Kuznetsov <vkuznets@redhat.com> - 2015-12-04 17:00 +0100
          Re: [Xen-devel] [PATCHv1] x86: rtc_cmos platform device requires  legacy irqs Boris Ostrovsky <boris.ostrovsky@oracle.com> - 2015-12-04 17:20 +0100
      Re: [Xen-devel] [PATCHv1] x86: rtc_cmos platform device requires  legacy irqs Thomas Gleixner <tglx@linutronix.de> - 2015-12-08 22:10 +0100
        Re: [Xen-devel] [PATCHv1] x86: rtc_cmos platform device requires  legacy irqs Boris Ostrovsky <boris.ostrovsky@oracle.com> - 2015-12-08 22:20 +0100
          Re: [Xen-devel] [PATCHv1] x86: rtc_cmos platform device requires  legacy irqs Thomas Gleixner <tglx@linutronix.de> - 2015-12-08 22:30 +0100

csiph-web