Re: linux-next: build failure after merge of the block tree

From	Matias Bjørling <m@bjorling.me>
Newsgroups	linux.kernel
Subject	Re: linux-next: build failure after merge of the block tree
Date	2015-12-03 09:40 +0100
Message-ID	<qBxAM-2vK-51@gated-at.bofh.it> (permalink)
References	<qBiim-161-7@gated-at.bofh.it> <qBiLp-1hG-43@gated-at.bofh.it> <qBmP1-47N-47@gated-at.bofh.it>
Organization	Paletta

Show all headers | View raw

On 12/02/2015 10:07 PM, Jens Axboe wrote:
> On 12/02/2015 09:45 AM, Christoph Hellwig wrote:
>> Looks like I didn't test with CONFIG_NVM enabled, and neither did
>> the build bot.
>>
>> Most of this is really weird crazy shit in the lighnvm support, though.
>>
>> Struct nvme_ns is a structure for the NVM I/O command set, and it has
>> no business poking into it.  Second this commit:
>>
>> commit 47b3115ae7b799be8b77b0f024215ad4f68d6460
>> Author: Wenwei Tao <ww.tao0320@gmail.com>
>> Date:   Fri Nov 20 13:47:55 2015 +0100
>>
>>      nvme: lightnvm: use admin queues for admin cmds
>>
>> Does even more crazy stuff.  If a function gets a request_queue parameter
>> passed it'd better use that and not look for another one.

A little crazy yes. The reason is that the NVMe admin queues and NVMe 
user queues are driven by different request queues. Previously this was 
patched up with having two queues in the lightnvm core. One for admin 
and another for user. But was later merged into a single queue.

We can pass both request queues into lightnvm core, but I prefer to 
handle it in some good way in the nvme-lightnvm integration.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

linux-next: build failure after merge of the block tree Mark Brown <broonie@kernel.org> - 2015-12-02 17:20 +0100
  Re: linux-next: build failure after merge of the block tree Christoph Hellwig <hch@lst.de> - 2015-12-02 17:50 +0100
    Re: linux-next: build failure after merge of the block tree Jens Axboe <axboe@kernel.dk> - 2015-12-02 22:10 +0100
      Re: linux-next: build failure after merge of the block tree Keith Busch <keith.busch@intel.com> - 2015-12-02 22:20 +0100
        Re: linux-next: build failure after merge of the block tree Jens Axboe <axboe@kernel.dk> - 2015-12-02 22:40 +0100
          Re: linux-next: build failure after merge of the block tree Christoph Hellwig <hch@lst.de> - 2015-12-03 08:40 +0100
      Re: linux-next: build failure after merge of the block tree Matias Bjørling <m@bjorling.me> - 2015-12-03 09:40 +0100
        Re: linux-next: build failure after merge of the block tree Christoph Hellwig <hch@lst.de> - 2015-12-03 10:10 +0100
          Re: linux-next: build failure after merge of the block tree Christoph Hellwig <hch@lst.de> - 2015-12-03 11:00 +0100
            Re: linux-next: build failure after merge of the block tree Matias Bjørling <m@bjorling.me> - 2015-12-03 11:10 +0100
              Re: linux-next: build failure after merge of the block tree Christoph Hellwig <hch@lst.de> - 2015-12-03 11:30 +0100
                Re: linux-next: build failure after merge of the block tree Matias Bjørling <m@bjorling.me> - 2015-12-03 12:10 +0100
                Re: linux-next: build failure after merge of the block tree Christoph Hellwig <hch@lst.de> - 2015-12-03 17:50 +0100
                Re: linux-next: build failure after merge of the block tree Matias Bjørling <m@bjorling.me> - 2015-12-04 13:20 +0100
          Re: linux-next: build failure after merge of the block tree Matias Bjørling <m@bjorling.me> - 2015-12-03 11:00 +0100

csiph-web