Re: linux-next: build failure after merge of the block tree

From	Jens Axboe <axboe@kernel.dk>
Newsgroups	linux.kernel
Subject	Re: linux-next: build failure after merge of the block tree
Date	2015-12-02 22:40 +0100
Message-ID	<qBni3-4hS-35@gated-at.bofh.it> (permalink)
References	<qBiim-161-7@gated-at.bofh.it> <qBiLp-1hG-43@gated-at.bofh.it> <qBmP1-47N-47@gated-at.bofh.it> <qBmYG-4b2-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On 12/02/2015 02:14 PM, Keith Busch wrote:
> On Wed, Dec 02, 2015 at 02:07:34PM -0700, Jens Axboe wrote:
>> Christoph, for-4.5/nvme also fails if integrity isn't enabled:
>
> I forgot about this since I've merged this in my repo to fix:
>
> https://lkml.org/lkml/2015/10/26/546
>
> That ok, or should we handle this differently?

I think that should make it compile, but the behavior will be a bit odd. 
If you pass in meta and integrity isn't enabled, you'll get an ENOMEM 
error. That seems a bit nonsensical.

We could make bio_integrity_alloc() return an error pointer. That way we 
could retain the ifdefs in the bip code, and not let it spread to drivers.

-- 
Jens Axboe

Thread

linux-next: build failure after merge of the block tree Mark Brown <broonie@kernel.org> - 2015-12-02 17:20 +0100
  Re: linux-next: build failure after merge of the block tree Christoph Hellwig <hch@lst.de> - 2015-12-02 17:50 +0100
    Re: linux-next: build failure after merge of the block tree Jens Axboe <axboe@kernel.dk> - 2015-12-02 22:10 +0100
      Re: linux-next: build failure after merge of the block tree Keith Busch <keith.busch@intel.com> - 2015-12-02 22:20 +0100
        Re: linux-next: build failure after merge of the block tree Jens Axboe <axboe@kernel.dk> - 2015-12-02 22:40 +0100
          Re: linux-next: build failure after merge of the block tree Christoph Hellwig <hch@lst.de> - 2015-12-03 08:40 +0100
      Re: linux-next: build failure after merge of the block tree Matias Bjørling <m@bjorling.me> - 2015-12-03 09:40 +0100
        Re: linux-next: build failure after merge of the block tree Christoph Hellwig <hch@lst.de> - 2015-12-03 10:10 +0100
          Re: linux-next: build failure after merge of the block tree Christoph Hellwig <hch@lst.de> - 2015-12-03 11:00 +0100
            Re: linux-next: build failure after merge of the block tree Matias Bjørling <m@bjorling.me> - 2015-12-03 11:10 +0100
              Re: linux-next: build failure after merge of the block tree Christoph Hellwig <hch@lst.de> - 2015-12-03 11:30 +0100
                Re: linux-next: build failure after merge of the block tree Matias Bjørling <m@bjorling.me> - 2015-12-03 12:10 +0100
                Re: linux-next: build failure after merge of the block tree Christoph Hellwig <hch@lst.de> - 2015-12-03 17:50 +0100
                Re: linux-next: build failure after merge of the block tree Matias Bjørling <m@bjorling.me> - 2015-12-04 13:20 +0100
          Re: linux-next: build failure after merge of the block tree Matias Bjørling <m@bjorling.me> - 2015-12-03 11:00 +0100

csiph-web