Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1281840
| From | Steven Rostedt <rostedt@goodmis.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v2 1/2] scripts: Add a recorduidiv program |
| Date | 2015-12-02 15:10 +0100 |
| Message-ID | <qBggB-8db-67@gated-at.bofh.it> (permalink) |
| References | (6 earlier) <qAWhP-3F3-19@gated-at.bofh.it> <qAWKS-45N-11@gated-at.bofh.it> <qAWUy-49J-11@gated-at.bofh.it> <qAXGW-4Gh-1@gated-at.bofh.it> <qBcPE-5Tr-37@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Wed, 2 Dec 2015 10:23:39 +0000
Russell King - ARM Linux <linux@arm.linux.org.uk> wrote:
> On Tue, Dec 01, 2015 at 06:16:43PM +0000, Russell King - ARM Linux wrote:
> > On Tue, Dec 01, 2015 at 12:22:12PM -0500, Steven Rostedt wrote:
> > > I guess another solution is to do a copy instead of modifying in place
> > > if it detects the multiple hard link?
> >
> > That would be the "transparent" solution. If you think it's worth
> > persuing, I'll have a go at fixing recordmcount to do that.
>
> Well, copying the file is easy - I've tested this and the linker
> appears happy with the result:
Want to make this into a proper patch and I'll start running it through
my tests?
-- Steve
>
> scripts/recordmcount.c | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/scripts/recordmcount.c b/scripts/recordmcount.c
> index 698768bdc581..91705ef30402 100644
> --- a/scripts/recordmcount.c
> +++ b/scripts/recordmcount.c
> @@ -211,6 +211,20 @@ static void *mmap_file(char const *fname)
> addr = umalloc(sb.st_size);
> uread(fd_map, addr, sb.st_size);
> }
> + if (sb.st_nlink != 1) {
> + /* file is hard-linked, break the hard link */
> + close(fd_map);
> + if (unlink(fname) < 0) {
> + perror(fname);
> + fail_file();
> + }
> + fd_map = open(fname, O_RDWR | O_CREAT, sb.st_mode);
> + if (fd_map < 0) {
> + perror(fname);
> + fail_file();
> + }
> + uwrite(fd_map, addr, sb.st_size);
> + }
> return addr;
> }
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Re: [PATCH v2 1/2] scripts: Add a recorduidiv program Russell King - ARM Linux <linux@arm.linux.org.uk> - 2015-11-30 16:40 +0100
Re: [PATCH v2 1/2] scripts: Add a recorduidiv program Michal Marek <mmarek@suse.com> - 2015-11-30 16:50 +0100
Re: [PATCH v2 1/2] scripts: Add a recorduidiv program Michal Marek <mmarek@suse.cz> - 2015-12-01 17:10 +0100
Re: [PATCH v2 1/2] scripts: Add a recorduidiv program Russell King - ARM Linux <linux@arm.linux.org.uk> - 2015-12-01 17:30 +0100
Re: [PATCH v2 1/2] scripts: Add a recorduidiv program Michal Marek <mmarek@suse.cz> - 2015-12-01 17:50 +0100
Re: [PATCH v2 1/2] scripts: Add a recorduidiv program Steven Rostedt <rostedt@goodmis.org> - 2015-12-01 17:50 +0100
Re: [PATCH v2 1/2] scripts: Add a recorduidiv program Russell King - ARM Linux <linux@arm.linux.org.uk> - 2015-12-01 18:20 +0100
Re: [PATCH v2 1/2] scripts: Add a recorduidiv program Steven Rostedt <rostedt@goodmis.org> - 2015-12-01 18:30 +0100
Re: [PATCH v2 1/2] scripts: Add a recorduidiv program Russell King - ARM Linux <linux@arm.linux.org.uk> - 2015-12-01 19:20 +0100
Re: [PATCH v2 1/2] scripts: Add a recorduidiv program Michal Marek <mmarek@suse.cz> - 2015-12-01 22:40 +0100
Re: [PATCH v2 1/2] scripts: Add a recorduidiv program Russell King - ARM Linux <linux@arm.linux.org.uk> - 2015-12-02 11:30 +0100
Re: [PATCH v2 1/2] scripts: Add a recorduidiv program Steven Rostedt <rostedt@goodmis.org> - 2015-12-02 15:10 +0100
Re: [PATCH] scripts: recordmcount: break hardlinks Steven Rostedt <rostedt@goodmis.org> - 2015-12-11 15:40 +0100
Re: [PATCH] scripts: recordmcount: break hardlinks Russell King - ARM Linux <linux@arm.linux.org.uk> - 2015-12-11 15:50 +0100
Re: [PATCH] scripts: recordmcount: break hardlinks Steven Rostedt <rostedt@goodmis.org> - 2015-12-11 16:10 +0100
Re: [PATCH] scripts: recordmcount: break hardlinks Steven Rostedt <rostedt@goodmis.org> - 2015-12-11 19:20 +0100
Re: [PATCH] scripts: recordmcount: break hardlinks Russell King - ARM Linux <linux@arm.linux.org.uk> - 2015-12-11 19:40 +0100
Re: [PATCH] scripts: recordmcount: break hardlinks Russell King - ARM Linux <linux@arm.linux.org.uk> - 2015-12-11 20:00 +0100
Re: [PATCH] scripts: recordmcount: break hardlinks Steven Rostedt <rostedt@goodmis.org> - 2015-12-11 20:30 +0100
Re: [PATCH] scripts: recordmcount: break hardlinks Steven Rostedt <rostedt@goodmis.org> - 2015-12-11 20:00 +0100
csiph-web