Re: [PATCH v2 1/2] scripts: Add a recorduidiv program

From	Michal Marek <mmarek@suse.cz>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 1/2] scripts: Add a recorduidiv program
Date	2015-12-01 17:50 +0100
Message-ID	<qAWhP-3F3-9@gated-at.bofh.it> (permalink)
References	(3 earlier) <qAype-5id-67@gated-at.bofh.it> <qAyIy-5q7-15@gated-at.bofh.it> <qAySe-5tX-5@gated-at.bofh.it> <qAVF7-3r6-7@gated-at.bofh.it> <qAVYw-3yp-45@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 2015-12-01 17:19, Russell King - ARM Linux wrote:
> On Tue, Dec 01, 2015 at 05:07:05PM +0100, Michal Marek wrote:
>> So, both recordmcount and the new recordudiv program are idempotent.
>> They check if the to-be-added section is already present and do nothing.
> 
> They hardly "do nothing", as the (eg) recordmcount plasters the build
> log with warnings.  A solution to that would be to make recordmcount
> silent if the section is already present.

Right, there is a warning. The recorduidiv program exits silently.


>> So the result is correct even with CCACHE_HARDLINK, just the
>> intermediate file might be incorrect. If this still is considered an
>> issue, I suggest clearing CCACHE_HARDLINK when using any of these
>> postprocessors, so as not to penalize other use cases.
> 
> Another solution would be to have the top level make file unset the
> CCACHE_HARDLINK environment variable if any of the options which enable
> in-place editing of object files is enabled.

This is what I meant, sorry for not being clear.


> Looking at the ccache
> code, the environment variable has to be deleted from the environment
> to turn off the option - and I'm not sure whether make can delete
> environment variables.  It certainly can override them, but I see
> nothing in the info pages which suggests that environment variables
> can be deleted by a makefile.

unexport CCACHE_HARDLINK

will do the trick.

Michal
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

Re: [PATCH v2 1/2] scripts: Add a recorduidiv program Russell King - ARM Linux <linux@arm.linux.org.uk> - 2015-11-30 16:40 +0100
  Re: [PATCH v2 1/2] scripts: Add a recorduidiv program Michal Marek <mmarek@suse.com> - 2015-11-30 16:50 +0100
    Re: [PATCH v2 1/2] scripts: Add a recorduidiv program Michal Marek <mmarek@suse.cz> - 2015-12-01 17:10 +0100
      Re: [PATCH v2 1/2] scripts: Add a recorduidiv program Russell King - ARM Linux <linux@arm.linux.org.uk> - 2015-12-01 17:30 +0100
        Re: [PATCH v2 1/2] scripts: Add a recorduidiv program Michal Marek <mmarek@suse.cz> - 2015-12-01 17:50 +0100
        Re: [PATCH v2 1/2] scripts: Add a recorduidiv program Steven Rostedt <rostedt@goodmis.org> - 2015-12-01 17:50 +0100
          Re: [PATCH v2 1/2] scripts: Add a recorduidiv program Russell King - ARM Linux <linux@arm.linux.org.uk> - 2015-12-01 18:20 +0100
            Re: [PATCH v2 1/2] scripts: Add a recorduidiv program Steven Rostedt <rostedt@goodmis.org> - 2015-12-01 18:30 +0100
              Re: [PATCH v2 1/2] scripts: Add a recorduidiv program Russell King - ARM Linux <linux@arm.linux.org.uk> - 2015-12-01 19:20 +0100
                Re: [PATCH v2 1/2] scripts: Add a recorduidiv program Michal Marek <mmarek@suse.cz> - 2015-12-01 22:40 +0100
                Re: [PATCH v2 1/2] scripts: Add a recorduidiv program Russell King - ARM Linux <linux@arm.linux.org.uk> - 2015-12-02 11:30 +0100
                Re: [PATCH v2 1/2] scripts: Add a recorduidiv program Steven Rostedt <rostedt@goodmis.org> - 2015-12-02 15:10 +0100
                Re: [PATCH] scripts: recordmcount: break hardlinks Steven Rostedt <rostedt@goodmis.org> - 2015-12-11 15:40 +0100
                Re: [PATCH] scripts: recordmcount: break hardlinks Russell King - ARM Linux <linux@arm.linux.org.uk> - 2015-12-11 15:50 +0100
                Re: [PATCH] scripts: recordmcount: break hardlinks Steven Rostedt <rostedt@goodmis.org> - 2015-12-11 16:10 +0100
                Re: [PATCH] scripts: recordmcount: break hardlinks Steven Rostedt <rostedt@goodmis.org> - 2015-12-11 19:20 +0100
                Re: [PATCH] scripts: recordmcount: break hardlinks Russell King - ARM Linux <linux@arm.linux.org.uk> - 2015-12-11 19:40 +0100
                Re: [PATCH] scripts: recordmcount: break hardlinks Russell King - ARM Linux <linux@arm.linux.org.uk> - 2015-12-11 20:00 +0100
                Re: [PATCH] scripts: recordmcount: break hardlinks Steven Rostedt <rostedt@goodmis.org> - 2015-12-11 20:30 +0100
                Re: [PATCH] scripts: recordmcount: break hardlinks Steven Rostedt <rostedt@goodmis.org> - 2015-12-11 20:00 +0100

csiph-web