Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1281749
| Path | csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod |
|---|---|
| From | Peter Zijlstra <peterz@infradead.org> |
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 2/7] nohz: New tick dependency mask |
| Date | Wed, 02 Dec 2015 13:50:01 +0100 |
| Message-ID | <qBf17-7eb-3@gated-at.bofh.it> (permalink) |
| References | <qunwt-7y6-9@gated-at.bofh.it> <qunwt-7y6-7@gated-at.bofh.it> <qB027-65N-25@gated-at.bofh.it> <qB1AS-79P-5@gated-at.bofh.it> |
| X-Original-To | Frederic Weisbecker <fweisbec@gmail.com> |
| MIME-Version | 1.0 |
| Content-Type | text/plain; charset=us-ascii |
| Content-Disposition | inline |
| User-Agent | Mutt/1.5.22.1 (2013-10-16) |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 36 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | LKML <linux-kernel@vger.kernel.org>, Chris Metcalf <cmetcalf@ezchip.com>, Thomas Gleixner <tglx@linutronix.de>, Luiz Capitulino <lcapitulino@redhat.com>, Christoph Lameter <cl@linux.com>, Ingo Molnar <mingo@kernel.org>, Viresh Kumar <viresh.kumar@linaro.org>, Rik van Riel <riel@redhat.com> |
| X-Original-Date | Wed, 2 Dec 2015 13:45:31 +0100 |
| X-Original-Message-ID | <20151202124531.GC9928@worktop.ger.corp.intel.com> |
| X-Original-References | <1447424529-13671-1-git-send-email-fweisbec@gmail.com> <1447424529-13671-3-git-send-email-fweisbec@gmail.com> <20151201204109.GN17308@twins.programming.kicks-ass.net> <20151201222025.GA31973@lerouge> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1281749 |
Show key headers only | View raw
On Tue, Dec 01, 2015 at 11:20:28PM +0100, Frederic Weisbecker wrote:
> > > +static void trace_tick_dependency(unsigned long dep)
> > > +{
> > > + if (dep & TICK_POSIX_TIMER_MASK) {
> > > + trace_tick_stop(0, "posix timers running\n");
> > > + return;
> > > + }
> > > +
> > > + if (dep & TICK_PERF_EVENTS_MASK) {
> > > + trace_tick_stop(0, "perf events running\n");
> > > + return;
> > > + }
> > > +
> > > + if (dep & TICK_SCHED_MASK) {
> > > + trace_tick_stop(0, "more than 1 task in runqueue\n");
> > > + return;
> > > + }
> > > +
> > > + if (dep & TICK_CLOCK_UNSTABLE_MASK)
> > > + trace_tick_stop(0, "unstable sched clock\n");
> > > +}
> >
> > I would suggest ditching the strings and using the
>
> Using a code value instead?
Duh, it seems I forgot to finish that sentence :/
I meant to say use the ftrace enum stuff. So yes, you encode a value and
the ftrace printing muck will generate a string if and when required.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Re: [PATCH 2/7] nohz: New tick dependency mask Peter Zijlstra <peterz@infradead.org> - 2015-12-01 21:50 +0100
Re: [PATCH 2/7] nohz: New tick dependency mask Frederic Weisbecker <fweisbec@gmail.com> - 2015-12-01 23:30 +0100
Re: [PATCH 2/7] nohz: New tick dependency mask Peter Zijlstra <peterz@infradead.org> - 2015-12-02 12:00 +0100
Re: [PATCH 2/7] nohz: New tick dependency mask Frederic Weisbecker <fweisbec@gmail.com> - 2015-12-02 15:10 +0100
Re: [PATCH 2/7] nohz: New tick dependency mask Peter Zijlstra <peterz@infradead.org> - 2015-12-02 16:10 +0100
Re: [PATCH 2/7] nohz: New tick dependency mask Frederic Weisbecker <fweisbec@gmail.com> - 2015-12-08 17:00 +0100
Re: [PATCH 2/7] nohz: New tick dependency mask Peter Zijlstra <peterz@infradead.org> - 2015-12-02 13:50 +0100
Re: [PATCH 2/7] nohz: New tick dependency mask Frederic Weisbecker <fweisbec@gmail.com> - 2015-12-02 15:20 +0100
Re: [PATCH 2/7] nohz: New tick dependency mask Peter Zijlstra <peterz@infradead.org> - 2015-12-02 13:50 +0100
Re: [PATCH 2/7] nohz: New tick dependency mask Frederic Weisbecker <fweisbec@gmail.com> - 2015-12-02 15:20 +0100
csiph-web