Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1281847
| From | Frederic Weisbecker <fweisbec@gmail.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 2/7] nohz: New tick dependency mask |
| Date | 2015-12-02 15:20 +0100 |
| Message-ID | <qBgqe-8gM-15@gated-at.bofh.it> (permalink) |
| References | <qunwt-7y6-9@gated-at.bofh.it> <qunwt-7y6-7@gated-at.bofh.it> <qB027-65N-25@gated-at.bofh.it> <qB1AS-79P-5@gated-at.bofh.it> <qBf17-7eb-3@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Wed, Dec 02, 2015 at 01:45:31PM +0100, Peter Zijlstra wrote:
> On Tue, Dec 01, 2015 at 11:20:28PM +0100, Frederic Weisbecker wrote:
>
> > > > +static void trace_tick_dependency(unsigned long dep)
> > > > +{
> > > > + if (dep & TICK_POSIX_TIMER_MASK) {
> > > > + trace_tick_stop(0, "posix timers running\n");
> > > > + return;
> > > > + }
> > > > +
> > > > + if (dep & TICK_PERF_EVENTS_MASK) {
> > > > + trace_tick_stop(0, "perf events running\n");
> > > > + return;
> > > > + }
> > > > +
> > > > + if (dep & TICK_SCHED_MASK) {
> > > > + trace_tick_stop(0, "more than 1 task in runqueue\n");
> > > > + return;
> > > > + }
> > > > +
> > > > + if (dep & TICK_CLOCK_UNSTABLE_MASK)
> > > > + trace_tick_stop(0, "unstable sched clock\n");
> > > > +}
> > >
> > > I would suggest ditching the strings and using the
> >
> > Using a code value instead?
>
> Duh, it seems I forgot to finish that sentence :/
>
> I meant to say use the ftrace enum stuff. So yes, you encode a value and
> the ftrace printing muck will generate a string if and when required.
Right I first wanted to avoid that because it makes parsing more complicated for
tools but probably it works fine now with libtraceevents.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Re: [PATCH 2/7] nohz: New tick dependency mask Peter Zijlstra <peterz@infradead.org> - 2015-12-01 21:50 +0100
Re: [PATCH 2/7] nohz: New tick dependency mask Frederic Weisbecker <fweisbec@gmail.com> - 2015-12-01 23:30 +0100
Re: [PATCH 2/7] nohz: New tick dependency mask Peter Zijlstra <peterz@infradead.org> - 2015-12-02 12:00 +0100
Re: [PATCH 2/7] nohz: New tick dependency mask Frederic Weisbecker <fweisbec@gmail.com> - 2015-12-02 15:10 +0100
Re: [PATCH 2/7] nohz: New tick dependency mask Peter Zijlstra <peterz@infradead.org> - 2015-12-02 16:10 +0100
Re: [PATCH 2/7] nohz: New tick dependency mask Frederic Weisbecker <fweisbec@gmail.com> - 2015-12-08 17:00 +0100
Re: [PATCH 2/7] nohz: New tick dependency mask Peter Zijlstra <peterz@infradead.org> - 2015-12-02 13:50 +0100
Re: [PATCH 2/7] nohz: New tick dependency mask Frederic Weisbecker <fweisbec@gmail.com> - 2015-12-02 15:20 +0100
Re: [PATCH 2/7] nohz: New tick dependency mask Peter Zijlstra <peterz@infradead.org> - 2015-12-02 13:50 +0100
Re: [PATCH 2/7] nohz: New tick dependency mask Frederic Weisbecker <fweisbec@gmail.com> - 2015-12-02 15:20 +0100
csiph-web