Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1281556
| From | Martyn Welch <martyn.welch@collabora.co.uk> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v2] Add support for monitoring Chrome OS firmware signals |
| Date | 2015-12-02 10:40 +0100 |
| Message-ID | <qBc3j-5mE-59@gated-at.bofh.it> (permalink) |
| References | <qAYD0-5ha-17@gated-at.bofh.it> <qAZIK-5Y4-9@gated-at.bofh.it> <qB8M1-3nY-7@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 02/12/15 06:08, Jeremiah Mahler wrote:
> Martyn,
>
> On Tue, Dec 01, 2015 at 08:19:46PM +0000, Martyn Welch wrote:
>> Select Chromebooks have gpio attached to signals used to cause the firmware
>> to enter alternative modes of operation and/or control other device
> [...]
>> +
>> +static int chromeos_firmware_probe(struct platform_device *pdev)
>> +{
>> + int err;
>> + struct chromeos_firmware_data *gpios;
>> +
>> + gpios = devm_kmalloc(&pdev->dev, sizeof(gpios), GFP_KERNEL);
>
> Should this be 'sizeof(*gpios)' so it allocates enough room for the
> entire struct instead of just the pointer?
>
Yes, you're right, it should.
Martyn
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Add support for Chrome OS firmware signals Martyn Welch <martyn.welch@collabora.co.uk> - 2015-12-01 20:20 +0100
[PATCH 2/3] Add support for monitoring Chrome OS firmware signals Martyn Welch <martyn.welch@collabora.co.uk> - 2015-12-01 20:20 +0100
[PATCH v2] Add support for monitoring Chrome OS firmware signals Martyn Welch <martyn.welch@collabora.co.uk> - 2015-12-01 21:30 +0100
Re: [PATCH v2] Add support for monitoring Chrome OS firmware signals Jeremiah Mahler <jmmahler@gmail.com> - 2015-12-02 07:10 +0100
Re: [PATCH v2] Add support for monitoring Chrome OS firmware signals Martyn Welch <martyn.welch@collabora.co.uk> - 2015-12-02 10:40 +0100
[PATCH v3] Add support for monitoring Chrome OS firmware signals Martyn Welch <martyn.welch@collabora.co.uk> - 2015-12-02 11:10 +0100
[PATCH 3/3] Addition of binding for firmware signals on peach-pi Martyn Welch <martyn.welch@collabora.co.uk> - 2015-12-01 20:20 +0100
Re: [PATCH 3/3] Addition of binding for firmware signals on peach-pi Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-12-02 01:00 +0100
Re: [PATCH 3/3] Addition of binding for firmware signals on peach-pi Martyn Welch <martyn.welch@collabora.co.uk> - 2015-12-02 10:40 +0100
Re: [PATCH 3/3] Addition of binding for firmware signals on peach-pi Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-12-03 01:20 +0100
csiph-web