Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1281540

Re: [PATCH 2/2] usb: pci-quirks: register USB mux found on Cherrytrail SOC

Show all headers | View raw

Hi Felipe,

> IMHO, this should be creating a child device instead of calling
> intel_usb_mux_register() directly. That way, your mux driver could
> actually _be_ a driver. Seems like all you need to do from this point is
> a register a simple platform_device which is a child of xhci, see
> platform_device_register_simple() for how to do this.
> 
> Or rather, platform_device_register_rsndata() passing xhci's device
> pointer as parent.

That was the plan originally, but unfortunately it does not work in
this case. It creates conflict as platform_device_add() call will then
claim part of io memory belonging to xHCI, making xHCI fail to probe.


Thanks,

-- 
heikki
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 2/2] usb: pci-quirks: register USB mux found on Cherrytrail SOC Heikki Krogerus <heikki.krogerus@linux.intel.com> - 2015-12-01 14:40 +0100
  Re: [PATCH 2/2] usb: pci-quirks: register USB mux found on Cherrytrail SOC Felipe Balbi <balbi@ti.com> - 2015-12-01 21:40 +0100
    Re: [PATCH 2/2] usb: pci-quirks: register USB mux found on  Cherrytrail SOC Heikki Krogerus <heikki.krogerus@linux.intel.com> - 2015-12-02 10:20 +0100
      Re: [PATCH 2/2] usb: pci-quirks: register USB mux found on Cherrytrail SOC Felipe Balbi <balbi@ti.com> - 2015-12-02 15:50 +0100
  Re: [PATCH 2/2] usb: pci-quirks: register USB mux found on  Cherrytrail SOC Lu Baolu <baolu.lu@linux.intel.com> - 2015-12-02 08:10 +0100
    Re: [PATCH 2/2] usb: pci-quirks: register USB mux found on  Cherrytrail SOC Heikki Krogerus <heikki.krogerus@linux.intel.com> - 2015-12-02 10:20 +0100

csiph-web