Re: [PATCH v2 2/2] x86_64: enable SWIOTLB if system has SRAT memory regions above MAX_DMA32_PFN

From	Ingo Molnar <mingo@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 2/2] x86_64: enable SWIOTLB if system has SRAT memory regions above MAX_DMA32_PFN
Date	2015-12-04 15:40 +0100
Message-ID	<qBZGG-3Ud-27@gated-at.bofh.it> (permalink)
References	<qBWIN-20f-11@gated-at.bofh.it> <qBWIN-20f-9@gated-at.bofh.it> <qBX2a-279-5@gated-at.bofh.it> <qBXOy-2Eq-19@gated-at.bofh.it> <qBXOy-2Eq-25@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

* Paolo Bonzini <pbonzini@redhat.com> wrote:

> On 04/12/2015 13:33, Igor Mammedov wrote:
> > That doesn't pass strict type check:
> > 
> > include/linux/kernel.h:730:17: warning: comparison of distinct pointer types lacks a cast [enabled by default]
> >   (void) (&_max1 == &_max2);  \
> >                  ^
> > arch/x86/mm/srat.c:206:21: note: in expansion of macro ‘max’
> >   max_possible_pfn = max(max_possible_pfn, PFN_UP(end - 1));
> > 
> > I can change max_possible_pfn to u64 to match PFN_UP(end - 1) type.
> 
> Sounds like a good idea anyway.

Yeah, agreed.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2 2/2] x86_64: enable SWIOTLB if system has SRAT memory regions above MAX_DMA32_PFN Igor Mammedov <imammedo@redhat.com> - 2015-12-04 12:30 +0100
  Re: [PATCH v2 2/2] x86_64: enable SWIOTLB if system has SRAT memory  regions above MAX_DMA32_PFN Ingo Molnar <mingo@kernel.org> - 2015-12-04 12:50 +0100
    Re: [PATCH v2 2/2] x86_64: enable SWIOTLB if system has SRAT memory  regions above MAX_DMA32_PFN Igor Mammedov <imammedo@redhat.com> - 2015-12-04 13:20 +0100
    Re: [PATCH v2 2/2] x86_64: enable SWIOTLB if system has SRAT memory  regions above MAX_DMA32_PFN Igor Mammedov <imammedo@redhat.com> - 2015-12-04 13:40 +0100
      Re: [PATCH v2 2/2] x86_64: enable SWIOTLB if system has SRAT memory  regions above MAX_DMA32_PFN Paolo Bonzini <pbonzini@redhat.com> - 2015-12-04 13:40 +0100
        Re: [PATCH v2 2/2] x86_64: enable SWIOTLB if system has SRAT memory  regions above MAX_DMA32_PFN Ingo Molnar <mingo@kernel.org> - 2015-12-04 15:40 +0100

csiph-web