Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1283142

Re: [PATCH 3/4] dmaengine: core: Introduce new, universal API to request a channel

Show all headers | View raw

On Thursday 03 December 2015 17:42:31 Peter Ujfalusi wrote:
> > 
> >> +       if (chan) {
> >> +               /* Valid channel found */
> >> +               if (!IS_ERR(chan) || PTR_ERR(chan) == -EPROBE_DEFER)
> >> +                       return chan;
> >> +
> >> +               pr_warn("%s: %s DMA request failed, falling back to legacy\n",
> >> +                       __func__, dev->of_node ? "OF" : "ACPI");
> >> +       }
> > 
> > Maybe print the error code as well?
> 
> Or remove the print altogether?
> In a healthy system we will either get the channel or the EPROBE_DEFER, in
> case of the platforms where the DT lookup does not work we expect errors and
> it is 'normal'.
> I think if we fail via DT/ACPI and we fail with legacy also then the client
> driver will say something about it anyways, or deal with it as it see fits.
> 

Right, that works too. It took me a while to figure out that we only get
there on systems that have ACPI or DT enabled for a particular device,
but where the normal method failed, rather than also systems with traditional
board files. Without the pr_warn, I would not have needed to think about
this ;-)

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/4] dmaengine: New 'universal' API for requesting channel Peter Ujfalusi <peter.ujfalusi@ti.com> - 2015-12-03 15:40 +0100
  [PATCH 4/4] dmaengine: edma: Add support for DMA filter mapping to slave devices Peter Ujfalusi <peter.ujfalusi@ti.com> - 2015-12-03 15:40 +0100
    Re: [PATCH 4/4] dmaengine: edma: Add support for DMA filter mapping to slave devices Arnd Bergmann <arnd@arndb.de> - 2015-12-03 16:40 +0100
      Re: [PATCH 4/4] dmaengine: edma: Add support for DMA filter mapping  to slave devices Peter Ujfalusi <peter.ujfalusi@ti.com> - 2015-12-03 16:50 +0100
        Re: [PATCH 4/4] dmaengine: edma: Add support for DMA filter mapping  to slave devices Peter Ujfalusi <peter.ujfalusi@ti.com> - 2015-12-08 14:20 +0100
  [PATCH 3/4] dmaengine: core: Introduce new, universal API to request a channel Peter Ujfalusi <peter.ujfalusi@ti.com> - 2015-12-03 15:40 +0100
    Re: [PATCH 3/4] dmaengine: core: Introduce new, universal API to request a channel Arnd Bergmann <arnd@arndb.de> - 2015-12-03 16:40 +0100
      Re: [PATCH 3/4] dmaengine: core: Introduce new, universal API to request a channel Arnd Bergmann <arnd@arndb.de> - 2015-12-03 16:50 +0100
      Re: [PATCH 3/4] dmaengine: core: Introduce new, universal API to  request a channel Peter Ujfalusi <peter.ujfalusi@ti.com> - 2015-12-03 16:50 +0100
    Re: [PATCH 3/4] dmaengine: core: Introduce new, universal API to  request a channel Andy Shevchenko <andy.shevchenko@gmail.com> - 2015-12-03 17:40 +0100
  Re: [PATCH 0/4] dmaengine: New 'universal' API for requesting channel Andy Shevchenko <andy.shevchenko@gmail.com> - 2015-12-03 17:40 +0100

csiph-web