Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1279830
| From | Marcin Wojtas <mw@semihalf.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH v4 net 3/6] net: mvneta: fix bit assignment for RX packet irq enable |
| Date | 2015-11-30 13:30 +0100 |
| Message-ID | <qAvKI-3zm-59@gated-at.bofh.it> (permalink) |
| References | <qAvKG-3zm-9@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
A value originally defined in the driver was inappropriate. Even though
the ingress was somehow working, writing MVNETA_RXQ_INTR_ENABLE_ALL_MASK
to MVNETA_INTR_ENABLE didn't make any effect, because the bits [31:16]
are reserved and read-only.
This commit updates MVNETA_RXQ_INTR_ENABLE_ALL_MASK to be compliant with
the controller's documentation.
Signed-off-by: Marcin Wojtas <mw@semihalf.com>
Fixes: c5aff18204da ("net: mvneta: driver for Marvell Armada 370/XP network
unit")
---
drivers/net/ethernet/marvell/mvneta.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/marvell/mvneta.c b/drivers/net/ethernet/marvell/mvneta.c
index 64c46f0..5dffb68 100644
--- a/drivers/net/ethernet/marvell/mvneta.c
+++ b/drivers/net/ethernet/marvell/mvneta.c
@@ -160,7 +160,7 @@
#define MVNETA_INTR_ENABLE 0x25b8
#define MVNETA_TXQ_INTR_ENABLE_ALL_MASK 0x0000ff00
-#define MVNETA_RXQ_INTR_ENABLE_ALL_MASK 0xff000000 // note: neta says it's 0x000000FF
+#define MVNETA_RXQ_INTR_ENABLE_ALL_MASK 0x000000ff
#define MVNETA_RXQ_CMD 0x2680
#define MVNETA_RXQ_DISABLE_SHIFT 8
--
1.8.3.1
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v4 net 0/6] Marvell Armada XP/370/38X Neta fixes Marcin Wojtas <mw@semihalf.com> - 2015-11-30 13:30 +0100
[PATCH v4 net 2/6] net: mvneta: fix bit assignment in MVNETA_RXQ_CONFIG_REG Marcin Wojtas <mw@semihalf.com> - 2015-11-30 13:30 +0100
[PATCH v4 net 3/6] net: mvneta: fix bit assignment for RX packet irq enable Marcin Wojtas <mw@semihalf.com> - 2015-11-30 13:30 +0100
[PATCH v4 net 4/6] net: mvneta: fix error path for building skb Marcin Wojtas <mw@semihalf.com> - 2015-11-30 13:30 +0100
[PATCH v4 net 1/6] net: mvneta: add configuration for MBUS windows access protection Marcin Wojtas <mw@semihalf.com> - 2015-11-30 13:30 +0100
[PATCH v4 net 6/6] mvebu: dts: enable IP checksum with jumbo frames for Armada 38x on Port0 Marcin Wojtas <mw@semihalf.com> - 2015-11-30 13:30 +0100
[PATCH v4 net 5/6] net: mvneta: enable setting custom TX IP checksum limit Marcin Wojtas <mw@semihalf.com> - 2015-11-30 13:30 +0100
Re: [PATCH v4 net 0/6] Marvell Armada XP/370/38X Neta fixes David Miller <davem@davemloft.net> - 2015-12-02 04:10 +0100
Re: [PATCH v4 net 0/6] Marvell Armada XP/370/38X Neta fixes Marcin Wojtas <mw@semihalf.com> - 2015-12-02 07:10 +0100
Re: [PATCH v4 net 0/6] Marvell Armada XP/370/38X Neta fixes Gregory CLEMENT <gregory.clement@free-electrons.com> - 2015-12-02 09:20 +0100
Re: [PATCH v4 net 0/6] Marvell Armada XP/370/38X Neta fixes David Miller <davem@davemloft.net> - 2015-12-02 21:40 +0100
Re: [PATCH v4 net 0/6] Marvell Armada XP/370/38X Neta fixes Gregory CLEMENT <gregory.clement@free-electrons.com> - 2015-12-03 14:50 +0100
csiph-web