Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1279829

Re: [PATCH] phy: sun9i-usb: add USB dependency

Show all headers | View raw

Hi,

On Mon, Nov 30, 2015 at 7:29 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> The sun9i usb phy driver calls of_usb_get_phy_mode(), which is not
> available if USB is disabled:
>
> drivers/built-in.o: In function `sun9i_usb_phy_probe':
> :(.text+0x7fb0): undefined reference to `of_usb_get_phy_mode'
>
> This adds a dependency to avoid the randconfig build errors.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 9c3b44302636 ("phy: Add driver to support individual USB PHYs on sun9i")
>
> diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig
> index 7eb5859dd035..03cb3ea2d2c0 100644
> --- a/drivers/phy/Kconfig
> +++ b/drivers/phy/Kconfig
> @@ -233,6 +233,7 @@ config PHY_SUN9I_USB
>         tristate "Allwinner sun9i SoC USB PHY driver"
>         depends on ARCH_SUNXI && HAS_IOMEM && OF
>         depends on RESET_CONTROLLER
> +       depends on USB_COMMON

USB_SUPPORT seems like the one to use. Some other phy drivers depend on this,
and so does drivers/usb/phy/of.c, which is where of_usb_get_phy_mode()
is located.

Thanks for catching this!


Regards
ChenYu

>         select GENERIC_PHY
>         help
>           Enable this to support the transceiver that is part of Allwinner
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] phy: sun9i-usb: add USB dependency Arnd Bergmann <arnd@arndb.de> - 2015-11-30 12:40 +0100
  Re: [PATCH] phy: sun9i-usb: add USB dependency Chen-Yu Tsai <wens@csie.org> - 2015-11-30 13:30 +0100
    Re: [PATCH] phy: sun9i-usb: add USB dependency Arnd Bergmann <arnd@arndb.de> - 2015-11-30 13:40 +0100
      Re: [PATCH] phy: sun9i-usb: add USB dependency Chen-Yu Tsai <wens@csie.org> - 2015-11-30 13:50 +0100

csiph-web