Re: [PATCH 1/2] regulator: Add coupled regulator

From	Mark Brown <broonie@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/2] regulator: Add coupled regulator
Date	2015-12-01 20:00 +0100
Message-ID	<qAYjF-4To-27@gated-at.bofh.it> (permalink)
References	<qAyyR-5lO-3@gated-at.bofh.it> <qAyyR-5lO-1@gated-at.bofh.it> <qAAhl-6vu-37@gated-at.bofh.it> <qATN0-2eD-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Tue, Dec 01, 2015 at 03:04:36PM +0100, Maxime Ripard wrote:
> On Mon, Nov 30, 2015 at 10:17:45AM -0700, Mathieu Poirier wrote:
> > On 30 November 2015 at 08:29, Maxime Ripard

> > > +       for (i = 0; i < creg->n_regulators; i++) {
> > > +               ret = regulator_disable(creg->regulators[i]);
> > > +               if (ret)
> > > +                       break;
> > > +       }

> > What happens to the other regulators when an element of the chain
> > fails to disable?  Should they be powered on again?

> That's actually a very good question, and I don't have a good answer
> to it. I guess the safest approach would be to roll back and do the
> opposite operation on the one we previously enabled / disabled.

> I wonder whether it might damage the hardware or not though.

> Mark?

Yeah, I'd expect us to try to unwind everything - presumably if the
supplies are partially enabled we'll not be able to satisfy the power
demands of whatever is connected (otherwise why would you create such an
innovative hardware design?) and it'll also mean that the refcounting
will be off if we ever try to do anything with the supply again.

Thread

[PATCH 1/2] regulator: Add coupled regulator Maxime Ripard <maxime.ripard@free-electrons.com> - 2015-11-30 16:30 +0100
  Re: [PATCH 1/2] regulator: Add coupled regulator Mark Brown <broonie@kernel.org> - 2015-11-30 17:50 +0100
  Re: [PATCH 1/2] regulator: Add coupled regulator Mathieu Poirier <mathieu.poirier@linaro.org> - 2015-11-30 18:20 +0100
    Re: [PATCH 1/2] regulator: Add coupled regulator Maxime Ripard <maxime.ripard@free-electrons.com> - 2015-12-01 15:10 +0100
      Re: [PATCH 1/2] regulator: Add coupled regulator Mark Brown <broonie@kernel.org> - 2015-12-01 20:00 +0100
  Re: [PATCH 1/2] regulator: Add coupled regulator Javier Martinez Canillas <javier@dowhile0.org> - 2015-11-30 20:10 +0100
    Re: [PATCH 1/2] regulator: Add coupled regulator Maxime Ripard <maxime.ripard@free-electrons.com> - 2015-12-01 22:40 +0100

csiph-web