Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1280211
| From | Javier Martinez Canillas <javier@dowhile0.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 1/2] regulator: Add coupled regulator |
| Date | 2015-11-30 20:10 +0100 |
| Message-ID | <qABZM-7C9-29@gated-at.bofh.it> (permalink) |
| References | <qAyyR-5lO-3@gated-at.bofh.it> <qAyyR-5lO-1@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Hello Maxime,
On Mon, Nov 30, 2015 at 12:29 PM, Maxime Ripard
<maxime.ripard@free-electrons.com> wrote:
[snip]
>
> +config REGULATOR_COUPLED_VOLTAGE
Shouldn't this depend on OF?
> + tristate "Coupled voltage regulator support"
the Kconfig symbol is tristate so the driver can be built as a module...
> +
> +static struct of_device_id coupled_regulator_of_match[] = {
> + { .compatible = "coupled-voltage-regulator" },
> + { /* Sentinel */ },
> +};
> +
...but the driver is missing a MODULE_DEVICE_TABLE(of, ...) so module
autoloading won't work.
Best regards,
Javier
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 0/2] regulator: Add support for parallel regulators Maxime Ripard <maxime.ripard@free-electrons.com> - 2015-11-30 16:30 +0100
[PATCH 2/2] ARM: sunxi: chip: Add Wifi chip Maxime Ripard <maxime.ripard@free-electrons.com> - 2015-11-30 16:30 +0100
[PATCH 1/2] regulator: Add coupled regulator Maxime Ripard <maxime.ripard@free-electrons.com> - 2015-11-30 16:30 +0100
Re: [PATCH 1/2] regulator: Add coupled regulator Mark Brown <broonie@kernel.org> - 2015-11-30 17:50 +0100
Re: [PATCH 1/2] regulator: Add coupled regulator Mathieu Poirier <mathieu.poirier@linaro.org> - 2015-11-30 18:20 +0100
Re: [PATCH 1/2] regulator: Add coupled regulator Maxime Ripard <maxime.ripard@free-electrons.com> - 2015-12-01 15:10 +0100
Re: [PATCH 1/2] regulator: Add coupled regulator Mark Brown <broonie@kernel.org> - 2015-12-01 20:00 +0100
Re: [PATCH 1/2] regulator: Add coupled regulator Javier Martinez Canillas <javier@dowhile0.org> - 2015-11-30 20:10 +0100
Re: [PATCH 1/2] regulator: Add coupled regulator Maxime Ripard <maxime.ripard@free-electrons.com> - 2015-12-01 22:40 +0100
csiph-web