Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1281080

Re: [PATCH v2 2/6] arm64: Move kill_cpu_early to smp.c

Path csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod
From "Suzuki K. Poulose" <Suzuki.Poulose@arm.com>
Newsgroups linux.kernel
Subject Re: [PATCH v2 2/6] arm64: Move kill_cpu_early to smp.c
Date Tue, 01 Dec 2015 18:40:02 +0100
Message-ID <qAX4e-4do-5@gated-at.bofh.it> (permalink)
References <qAUSJ-2T0-7@gated-at.bofh.it> <qAUSL-2T0-47@gated-at.bofh.it> <qAV2q-2WT-19@gated-at.bofh.it> <qAVF7-3r6-5@gated-at.bofh.it> <qAW8a-3BH-17@gated-at.bofh.it>
X-Original-To Mark Rutland <mark.rutland@arm.com>
User-Agent Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0
MIME-Version 1.0
X-Originalarrivaltime 01 Dec 2015 17:38:54.0824 (UTC) FILETIME=[2666C680:01D12C5F]
X-Mc-Unique XoCypDE-T16Hkl-hxmpssw-1
Content-Type text/plain; charset=WINDOWS-1252; format=flowed
Content-Transfer-Encoding 8BIT
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 39
Organization linux.* mail to news gateway
X-Original-Cc linux-arm-kernel@lists.infradead.org, marc.zyngier@arm.com, linux-kernel@vger.kernel.org, will.deacon@arm.com, catalin.marinas@arm.com
X-Original-Date Tue, 1 Dec 2015 17:38:54 +0000
X-Original-Message-ID <565DDB2E.2010308@arm.com>
X-Original-References <1448982731-17182-1-git-send-email-suzuki.poulose@arm.com> <1448982731-17182-3-git-send-email-suzuki.poulose@arm.com> <20151201152826.GA28370@leverpostej> <565DC5DB.7070905@arm.com> <20151201163138.GA29045@leverpostej>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1281080

Show key headers only | View raw


On 01/12/15 16:31, Mark Rutland wrote:
> For PSCI 0.2+ we can query AFFINITY_INFO to discover whether a CPU is
> whether or not it is in the firmware (i.e. whether or not it is
> potentially in the kernel), so we can certainly query this in some
> cases.
>
> We already do this in the usual hotplug-off case; see cpu_kill.

OK, good to know.

>> Correct, I didn't think about kexec. May be we could indicate the result
>> back (that we are looping in kernel) in secondary_data and that could solve
>> the synchronisation part ?
>
> I think we need to have two flags, a cpu-must-die flag in secondary
> data, and a global stuck-in-the-kernel flag.
>
> The CPU wanting to die could set its cpu-must-die flag, signal the
> completion, then cpu_die(). The CPU awaiting the completion would then
> check cpu-must-die, and if so, cpu_kill() that CPU. If not set, we had a
> successful onlining.

Correct.

>
> We need stuck-in-the-kernel flag to account for CPUs which didn't manage
> to turn the MMU on (which are either in the spin-table, or failed when
> they were individually onlined).

Did you mean to say "turn the MMU off" ?

Cheers
Suzuki

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH v2 0/6] arm64: cpufeature: Add sanity check for ASIDBits "Suzuki K. Poulose" <suzuki.poulose@arm.com> - 2015-12-01 16:20 +0100
  [PATCH v2 4/6] arm64: Add hook for checking early CPU features "Suzuki K. Poulose" <suzuki.poulose@arm.com> - 2015-12-01 16:20 +0100
  [PATCH v2 1/6] arm64: Introduce kill_cpu_early "Suzuki K. Poulose" <suzuki.poulose@arm.com> - 2015-12-01 16:20 +0100
  [PATCH v2 2/6] arm64: Move kill_cpu_early to smp.c "Suzuki K. Poulose" <suzuki.poulose@arm.com> - 2015-12-01 16:20 +0100
    Re: [PATCH v2 2/6] arm64: Move kill_cpu_early to smp.c Mark Rutland <mark.rutland@arm.com> - 2015-12-01 16:30 +0100
      Re: [PATCH v2 2/6] arm64: Move kill_cpu_early to smp.c "Suzuki K. Poulose" <Suzuki.Poulose@arm.com> - 2015-12-01 17:10 +0100
        Re: [PATCH v2 2/6] arm64: Move kill_cpu_early to smp.c Mark Rutland <mark.rutland@arm.com> - 2015-12-01 17:40 +0100
          Re: [PATCH v2 2/6] arm64: Move kill_cpu_early to smp.c "Suzuki K. Poulose" <Suzuki.Poulose@arm.com> - 2015-12-01 18:40 +0100
            Re: [PATCH v2 2/6] arm64: Move kill_cpu_early to smp.c Mark Rutland <mark.rutland@arm.com> - 2015-12-01 19:00 +0100
              Re: [PATCH v2 2/6] arm64: Move kill_cpu_early to smp.c "Suzuki K. Poulose" <Suzuki.Poulose@arm.com> - 2015-12-01 19:20 +0100
                Re: [PATCH v2 2/6] arm64: Move kill_cpu_early to smp.c Mark Rutland <mark.rutland@arm.com> - 2015-12-01 20:00 +0100
                Re: [PATCH v2 2/6] arm64: Move kill_cpu_early to smp.c "Suzuki K. Poulose" <Suzuki.Poulose@arm.com> - 2015-12-03 17:40 +0100
                Re: [PATCH v2 2/6] arm64: Move kill_cpu_early to smp.c Mark Rutland <mark.rutland@arm.com> - 2015-12-03 18:10 +0100
  [PATCH v2 6/6] arm64: Ensure the secondary CPUs have safe ASIDBits size "Suzuki K. Poulose" <suzuki.poulose@arm.com> - 2015-12-01 16:20 +0100
  [PATCH v2 5/6] arm64: Add helper for extracting ASIDBits "Suzuki K. Poulose" <suzuki.poulose@arm.com> - 2015-12-01 16:20 +0100

csiph-web