Path: csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod From: "Suzuki K. Poulose" Newsgroups: linux.kernel Subject: Re: [PATCH v2 2/6] arm64: Move kill_cpu_early to smp.c Date: Tue, 01 Dec 2015 18:40:02 +0100 Message-ID: References: X-Original-To: Mark Rutland User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 X-Originalarrivaltime: 01 Dec 2015 17:38:54.0824 (UTC) FILETIME=[2666C680:01D12C5F] X-Mc-Unique: XoCypDE-T16Hkl-hxmpssw-1 Content-Type: text/plain; charset=WINDOWS-1252; format=flowed Content-Transfer-Encoding: 8BIT Sender: robomod@news.nic.it List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Approved: robomod@news.nic.it Lines: 39 Organization: linux.* mail to news gateway X-Original-Cc: linux-arm-kernel@lists.infradead.org, marc.zyngier@arm.com, linux-kernel@vger.kernel.org, will.deacon@arm.com, catalin.marinas@arm.com X-Original-Date: Tue, 1 Dec 2015 17:38:54 +0000 X-Original-Message-ID: <565DDB2E.2010308@arm.com> X-Original-References: <1448982731-17182-1-git-send-email-suzuki.poulose@arm.com> <1448982731-17182-3-git-send-email-suzuki.poulose@arm.com> <20151201152826.GA28370@leverpostej> <565DC5DB.7070905@arm.com> <20151201163138.GA29045@leverpostej> X-Original-Sender: linux-kernel-owner@vger.kernel.org Xref: csiph.com linux.kernel:1281080 On 01/12/15 16:31, Mark Rutland wrote: > For PSCI 0.2+ we can query AFFINITY_INFO to discover whether a CPU is > whether or not it is in the firmware (i.e. whether or not it is > potentially in the kernel), so we can certainly query this in some > cases. > > We already do this in the usual hotplug-off case; see cpu_kill. OK, good to know. >> Correct, I didn't think about kexec. May be we could indicate the result >> back (that we are looping in kernel) in secondary_data and that could solve >> the synchronisation part ? > > I think we need to have two flags, a cpu-must-die flag in secondary > data, and a global stuck-in-the-kernel flag. > > The CPU wanting to die could set its cpu-must-die flag, signal the > completion, then cpu_die(). The CPU awaiting the completion would then > check cpu-must-die, and if so, cpu_kill() that CPU. If not set, we had a > successful onlining. Correct. > > We need stuck-in-the-kernel flag to account for CPUs which didn't manage > to turn the MMU on (which are either in the spin-table, or failed when > they were individually onlined). Did you mean to say "turn the MMU off" ? Cheers Suzuki -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/