Re: [tpmdd-devel] [PATCH 2/2] tpm_tis: Clean up the force=1 module parameter

Path	csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod
From	Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
Newsgroups	linux.kernel
Subject	Re: [tpmdd-devel] [PATCH 2/2] tpm_tis: Clean up the force=1 module parameter
Date	Tue, 01 Dec 2015 18:40:01 +0100
Message-ID	<qAX4d-4do-3@gated-at.bofh.it> (permalink)
References	<qACj8-7Iu-9@gated-at.bofh.it> <qACj8-7Iu-11@gated-at.bofh.it> <qARLc-Ht-19@gated-at.bofh.it>
X-Original-To	"Wilck, Martin" <martin.wilck@ts.fujitsu.com>
Dkim-Signature	v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=obsidianresearch.com; s=rsa1; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date; bh=YspuHbor2e6eKRuQHMhypKEo2XMdRzZJmiZ9EjJIREs=; b=l23wlBpE0soM5qJplpBJcz4DSPR0GQA1BrJ+H4hiDmSQ7OAyI0GuDtPVdO7QGBEPhj70+1TtE9QQXlICxhQqsLXIAZ74G7BZZwnO6ntIuUE/bdQf3pnNjnlqM+LVtChwclXl3IbCn4+uAuOsX8wduccn4vgJZzSrSeKnTxxuf6E=;
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	Mutt/1.5.23 (2014-03-12)
X-Broken-Reverse-Dns	no host name found for IP address 10.0.0.160
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	25
Organization	linux.* mail to news gateway
X-Original-Cc	Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>, "tpmdd-devel@lists.sourceforge.net" <tpmdd-devel@lists.sourceforge.net>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, 'Uwe Kleine-König' <u.kleine-koenig@pengutronix.de>
X-Original-Date	Tue, 1 Dec 2015 10:39:40 -0700
X-Original-Message-ID	<20151201173940.GC691@obsidianresearch.com>
X-Original-References	<1448911632-20070-1-git-send-email-jgunthorpe@obsidianresearch.com> <1448911632-20070-3-git-send-email-jgunthorpe@obsidianresearch.com> <C5A28EF7B98F574C85C70238C8E9ECC04E682BF14F@ABGEX74E.FSC.NET>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1281079

Show key headers only | View raw

On Tue, Dec 01, 2015 at 12:50:28PM +0100, Wilck, Martin wrote:

> The patch introduces one user-visible change, because now the ACPI and
> PnP drivers are registered even with "force=1". This causes my TPM to be
> show up twice in sysfs:

Registering all the drivers is deliberate, IMHO, force should not be
used if the driver binds normally.

However, getting two is a bug, and it is because tpm_tis is not doing
resource management.

I'll add another patch to fix that..

Also, I'll change the order of the driver registers so that the
platform driver goes first, that way if force is used the platform
driver will bind and still auto probe irqs and then the other drivers
will bounce off the claimed resource.

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 2/2] tpm_tis: Clean up the force=1 module parameter Jason Gunthorpe <jgunthorpe@obsidianresearch.com> - 2015-11-30 20:30 +0100
  Re: [PATCH 2/2] tpm_tis: Clean up the force=1 module parameter Uwe Kleine-König   <u.kleine-koenig@pengutronix.de> - 2015-12-01 08:30 +0100
    Re: [PATCH 2/2] tpm_tis: Clean up the force=1 module parameter Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2015-12-01 09:40 +0100
      Re: [PATCH 2/2] tpm_tis: Clean up the force=1 module parameter Jason Gunthorpe <jgunthorpe@obsidianresearch.com> - 2015-12-01 18:50 +0100
        Re: [PATCH 2/2] tpm_tis: Clean up the force=1 module parameter Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2015-12-01 22:00 +0100
    Re: [PATCH 2/2] tpm_tis: Clean up the force=1 module parameter Jason Gunthorpe <jgunthorpe@obsidianresearch.com> - 2015-12-01 18:40 +0100
  Re: [tpmdd-devel] [PATCH 2/2] tpm_tis: Clean up the force=1 module  parameter "Wilck, Martin" <martin.wilck@ts.fujitsu.com> - 2015-12-01 13:00 +0100
    Re: [tpmdd-devel] [PATCH 2/2] tpm_tis: Clean up the force=1 module  parameter Jason Gunthorpe <jgunthorpe@obsidianresearch.com> - 2015-12-01 18:40 +0100

csiph-web