Re: [PATCH 2/2] tpm_tis: Clean up the force=1 module parameter

From	Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/2] tpm_tis: Clean up the force=1 module parameter
Date	2015-12-01 18:50 +0100
Message-ID	<qAXdU-4h1-5@gated-at.bofh.it> (permalink)
References	<qACj8-7Iu-9@gated-at.bofh.it> <qACj8-7Iu-11@gated-at.bofh.it> <qANxT-6yD-5@gated-at.bofh.it> <qAODE-7cY-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Dec 01, 2015 at 10:35:08AM +0200, Jarkko Sakkinen wrote:

> In addition I want this fix as a single patch, not as two-patch set.
> The first patch might have made sense when the fix was being developed
> but now it's just really akward change.

No, you are not in tune with the kernel standard when you are
suggesting merging these patches. Each patch is self contained, encompasses a
single idea/change, and is justifiable on its own.

Ie SubmittingPatches explains:

 The point to remember is that each patch should make an easily understood
 change that can be verified by reviewers.  Each patch should be
 justifiable on its own merits.

If anything the larger patch should be split, because there is alot
going on there..

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCH 2/2] tpm_tis: Clean up the force=1 module parameter Jason Gunthorpe <jgunthorpe@obsidianresearch.com> - 2015-11-30 20:30 +0100
  Re: [PATCH 2/2] tpm_tis: Clean up the force=1 module parameter Uwe Kleine-König   <u.kleine-koenig@pengutronix.de> - 2015-12-01 08:30 +0100
    Re: [PATCH 2/2] tpm_tis: Clean up the force=1 module parameter Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2015-12-01 09:40 +0100
      Re: [PATCH 2/2] tpm_tis: Clean up the force=1 module parameter Jason Gunthorpe <jgunthorpe@obsidianresearch.com> - 2015-12-01 18:50 +0100
        Re: [PATCH 2/2] tpm_tis: Clean up the force=1 module parameter Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2015-12-01 22:00 +0100
    Re: [PATCH 2/2] tpm_tis: Clean up the force=1 module parameter Jason Gunthorpe <jgunthorpe@obsidianresearch.com> - 2015-12-01 18:40 +0100
  Re: [tpmdd-devel] [PATCH 2/2] tpm_tis: Clean up the force=1 module  parameter "Wilck, Martin" <martin.wilck@ts.fujitsu.com> - 2015-12-01 13:00 +0100
    Re: [tpmdd-devel] [PATCH 2/2] tpm_tis: Clean up the force=1 module  parameter Jason Gunthorpe <jgunthorpe@obsidianresearch.com> - 2015-12-01 18:40 +0100

csiph-web