Re: [PATCH 1/2] zram: pass gfp from zcomp frontend to backend

Path	csiph.com!au2pb.net!feeder.erje.net!2.us.feeder.erje.net!newsfeed.fsmpi.rwth-aachen.de!newsfeed.straub-nv.de!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod
From	Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/2] zram: pass gfp from zcomp frontend to backend
Date	Tue, 01 Dec 2015 01:50:01 +0100
Message-ID	<qAHiN-2re-3@gated-at.bofh.it> (permalink)
References	<qziPw-6lh-5@gated-at.bofh.it> <qziPw-6lh-11@gated-at.bofh.it> <qAGPL-2hv-5@gated-at.bofh.it>
X-Original-To	Andrew Morton <akpm@linux-foundation.org>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=NeJ/CqixTlyyuSUwXEYS7kabcuBGYJZyIDQCJ4fITBI=; b=h49vw4j4tHQOENs97TTWf0oSWNkh60xjJns+1+yTfOrv5oYcUxr0Bc97wWwASKg6mx J3NzIlcfbGHAfVHBWaye1kpuXOFqs92IekHu0nlwM4yXWd3+DY7NCRjvZ7kCY+t6AoU5 78xkanbVoWZmHNABIr9vT5bUgICtpExEVz+QMpf9U6Cm0tXehYyiyyka6OHxLeBwe1vL a/J56qcCR6w6lNYKlP6VquwT0F9LauTk3QGdl3QMaIi+ZElYZiYGpWtoti3PimJmUIVU 5kbUeZGOw9qa1+gmYjhKO9ji4kUvoxlRTRj3lUdH5VFyh7tc/1BC6ra17nSP6oFp9B/D JYSQ==
X-Received	by 10.98.10.83 with SMTP id s80mr66217163pfi.79.1448930619690; Mon, 30 Nov 2015 16:43:39 -0800 (PST)
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	Mutt/1.5.24 (2015-08-30)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	29
Organization	linux.* mail to news gateway
X-Original-Cc	Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>, Minchan Kim <minchan@kernel.org>, linux-kernel@vger.kernel.org, Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
X-Original-Date	Tue, 1 Dec 2015 09:44:41 +0900
X-Original-Message-ID	<20151201004441.GB653@swordfish>
X-Original-References	<1448598194-24754-1-git-send-email-sergey.senozhatsky@gmail.com> <1448598194-24754-2-git-send-email-sergey.senozhatsky@gmail.com> <20151130161004.171a80a7f618a2c55ff885c6@linux-foundation.org>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1280432

Show key headers only | View raw

On (11/30/15 16:10), Andrew Morton wrote:
> > From: Minchan Kim <minchan@kernel.org>
> > 
> > Each zcomp backend uses own gfp flag but it's pointless
> > because the context they could be called is driven by upper
> > layer(ie, zcomp frontend). As well, zcomp frondend could
> > call them in different context. One context(ie, zram init part)
> > is it should be better to make sure successful allocation
> > other context(ie, further stream allocation part for accelarating
> > I/O speed) is just optional so let's pass gfp down from driver
> > (ie, zcomp frontend) like normal MM convention.
> > 
> > [sergey: add missing __vmalloc zero and highmem gfps]
> > Signed-off-by: Minchan Kim <minchan@kernel.org>
> > Acked-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
> 
> I changed this to signed-off-by:you.  Documentation/SubmittingPatches
> section 11 explains why ;)

Thank you.

> (Hm, rule (c) is recursive.  Nice!)

	-ss
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCH 0/2] zram: cleanup stream's ->private allocation code Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2015-11-27 05:30 +0100
  [PATCH 1/2] zram: pass gfp from zcomp frontend to backend Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2015-11-27 05:30 +0100
    Re: [PATCH 1/2] zram: pass gfp from zcomp frontend to backend Andrew Morton <akpm@linux-foundation.org> - 2015-12-01 01:20 +0100
      Re: [PATCH 1/2] zram: pass gfp from zcomp frontend to backend Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2015-12-01 01:50 +0100
  [PATCH 2/2] zram/zcomp: do not zero out zcomp private pages Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2015-11-27 05:30 +0100
    Re: [PATCH 2/2] zram/zcomp: do not zero out zcomp private pages Minchan Kim <minchan@kernel.org> - 2015-11-30 08:20 +0100

csiph-web