Re: [PATCH 1/2] zram: pass gfp from zcomp frontend to backend

From	Andrew Morton <akpm@linux-foundation.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/2] zram: pass gfp from zcomp frontend to backend
Date	2015-12-01 01:20 +0100
Message-ID	<qAGPL-2hv-5@gated-at.bofh.it> (permalink)
References	<qziPw-6lh-5@gated-at.bofh.it> <qziPw-6lh-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, 27 Nov 2015 13:23:13 +0900 Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> wrote:

> From: Minchan Kim <minchan@kernel.org>
> 
> Each zcomp backend uses own gfp flag but it's pointless
> because the context they could be called is driven by upper
> layer(ie, zcomp frontend). As well, zcomp frondend could
> call them in different context. One context(ie, zram init part)
> is it should be better to make sure successful allocation
> other context(ie, further stream allocation part for accelarating
> I/O speed) is just optional so let's pass gfp down from driver
> (ie, zcomp frontend) like normal MM convention.
> 
> [sergey: add missing __vmalloc zero and highmem gfps]
> Signed-off-by: Minchan Kim <minchan@kernel.org>
> Acked-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>

I changed this to signed-off-by:you.  Documentation/SubmittingPatches
section 11 explains why ;)

(Hm, rule (c) is recursive.  Nice!)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCH 0/2] zram: cleanup stream's ->private allocation code Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2015-11-27 05:30 +0100
  [PATCH 1/2] zram: pass gfp from zcomp frontend to backend Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2015-11-27 05:30 +0100
    Re: [PATCH 1/2] zram: pass gfp from zcomp frontend to backend Andrew Morton <akpm@linux-foundation.org> - 2015-12-01 01:20 +0100
      Re: [PATCH 1/2] zram: pass gfp from zcomp frontend to backend Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2015-12-01 01:50 +0100
  [PATCH 2/2] zram/zcomp: do not zero out zcomp private pages Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2015-11-27 05:30 +0100
    Re: [PATCH 2/2] zram/zcomp: do not zero out zcomp private pages Minchan Kim <minchan@kernel.org> - 2015-11-30 08:20 +0100

csiph-web