Re: [PATCH] clk: sunxi: pll2: Fix clock running too fast

From	Maxime Ripard <maxime.ripard@free-electrons.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] clk: sunxi: pll2: Fix clock running too fast
Date	2015-11-30 21:20 +0100
Message-ID	<qAD5v-8hq-3@gated-at.bofh.it> (permalink)
References	<qAyIy-5q7-23@gated-at.bofh.it> <qACsN-7MQ-21@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Mon, Nov 30, 2015 at 11:32:16AM -0800, Stephen Boyd wrote:
> On 11/30, Maxime Ripard wrote:
> > @@ -191,25 +186,17 @@ err_unmap:
> >  	iounmap(reg);
> >  }
> >  
> > -static struct sun4i_pll2_data sun4i_a10_pll2_data = {
> > -	.pre_div_flags	= CLK_DIVIDER_ONE_BASED | CLK_DIVIDER_ALLOW_ZERO,
> > -};
> > -
> >  static void __init sun4i_a10_pll2_setup(struct device_node *node)
> >  {
> > -	sun4i_pll2_setup(node, &sun4i_a10_pll2_data);
> > +	sun4i_pll2_setup(node, &sun4i_a10_pll2_data, 0);
> 
> And it doesn't compile, because we just deleted the data that
> this is taking an address of. Hmph.

Sorry for the screw up, I'll resend a new version tomorrow...

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] clk: sunxi: pll2: Fix clock running too fast Maxime Ripard <maxime.ripard@free-electrons.com> - 2015-11-30 16:40 +0100
  Re: [PATCH] clk: sunxi: pll2: Fix clock running too fast Stephen Boyd <sboyd@codeaurora.org> - 2015-11-30 20:30 +0100
  Re: [PATCH] clk: sunxi: pll2: Fix clock running too fast Stephen Boyd <sboyd@codeaurora.org> - 2015-11-30 20:40 +0100
    Re: [PATCH] clk: sunxi: pll2: Fix clock running too fast Maxime Ripard <maxime.ripard@free-electrons.com> - 2015-11-30 21:20 +0100

csiph-web