Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1280225

Re: [PATCH] clk: sunxi: pll2: Fix clock running too fast

From Stephen Boyd <sboyd@codeaurora.org>
Newsgroups linux.kernel
Subject Re: [PATCH] clk: sunxi: pll2: Fix clock running too fast
Date 2015-11-30 20:40 +0100
Message-ID <qACsN-7MQ-21@gated-at.bofh.it> (permalink)
References <qAyIy-5q7-23@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On 11/30, Maxime Ripard wrote:
> @@ -191,25 +186,17 @@ err_unmap:
>  	iounmap(reg);
>  }
>  
> -static struct sun4i_pll2_data sun4i_a10_pll2_data = {
> -	.pre_div_flags	= CLK_DIVIDER_ONE_BASED | CLK_DIVIDER_ALLOW_ZERO,
> -};
> -
>  static void __init sun4i_a10_pll2_setup(struct device_node *node)
>  {
> -	sun4i_pll2_setup(node, &sun4i_a10_pll2_data);
> +	sun4i_pll2_setup(node, &sun4i_a10_pll2_data, 0);

And it doesn't compile, because we just deleted the data that
this is taking an address of. Hmph.

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] clk: sunxi: pll2: Fix clock running too fast Maxime Ripard <maxime.ripard@free-electrons.com> - 2015-11-30 16:40 +0100
  Re: [PATCH] clk: sunxi: pll2: Fix clock running too fast Stephen Boyd <sboyd@codeaurora.org> - 2015-11-30 20:30 +0100
  Re: [PATCH] clk: sunxi: pll2: Fix clock running too fast Stephen Boyd <sboyd@codeaurora.org> - 2015-11-30 20:40 +0100
    Re: [PATCH] clk: sunxi: pll2: Fix clock running too fast Maxime Ripard <maxime.ripard@free-electrons.com> - 2015-11-30 21:20 +0100

csiph-web