Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1227395

[PATCH RESEND 3/3] storvsc: Don't set the SRB_FLAGS_QUEUE_ACTION_ENABLE flag

From "K. Y. Srinivasan" <kys@microsoft.com>
Newsgroups linux.kernel
Subject [PATCH RESEND 3/3] storvsc: Don't set the SRB_FLAGS_QUEUE_ACTION_ENABLE flag
Date 2015-09-17 23:10 +0200
Message-ID <q9OBk-78U-21@gated-at.bofh.it> (permalink)
References <q9OBj-78U-5@gated-at.bofh.it> <q9OBk-78U-15@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Don't set the SRB_FLAGS_QUEUE_ACTION_ENABLE flag since we are not specifying
tags. Qlogic driver does not work correctly if the SRB_FLAGS_QUEUE_ACTION_ENABLE
is set and no action tag is specified.

Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
Tested-by: Vivek Yadav <vyadav@microsoft.com>
Reviewed-by: Long Li <longli@microsoft.com>
---
 drivers/scsi/storvsc_drv.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/drivers/scsi/storvsc_drv.c b/drivers/scsi/storvsc_drv.c
index bce131b..9c8db21 100644
--- a/drivers/scsi/storvsc_drv.c
+++ b/drivers/scsi/storvsc_drv.c
@@ -1647,8 +1647,7 @@ static int storvsc_queuecommand(struct Scsi_Host *host, struct scsi_cmnd *scmnd)
 	vm_srb->win8_extension.time_out_value = 60;
 
 	vm_srb->win8_extension.srb_flags |=
-		(SRB_FLAGS_QUEUE_ACTION_ENABLE |
-		SRB_FLAGS_DISABLE_SYNCH_TRANSFER);
+		SRB_FLAGS_DISABLE_SYNCH_TRANSFER;
 
 	/* Build the SRB */
 	switch (scmnd->sc_data_direction) {
-- 
1.7.4.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 0/3] scsi: Some miscellaneous fixes  "K. Y. Srinivasan" <kys@microsoft.com> - 2015-09-17 23:10 +0200
  [PATCH 2/3] scsi: introduce short_inquiry flag for broken host adapters "K. Y. Srinivasan" <kys@microsoft.com> - 2015-09-17 23:10 +0200
  [PATCH RESEND  3/3] storvsc: Don't set the SRB_FLAGS_QUEUE_ACTION_ENABLE flag "K. Y. Srinivasan" <kys@microsoft.com> - 2015-09-17 23:10 +0200
  [PATCH 1/3] scsi_scan: don't dump trace when scsi_prep_async_scan() is called twice "K. Y. Srinivasan" <kys@microsoft.com> - 2015-09-17 23:10 +0200

csiph-web