Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1227396

[PATCH 1/3] scsi_scan: don't dump trace when scsi_prep_async_scan() is called twice

Show all headers | View raw

From: Vitaly Kuznetsov <vkuznets@redhat.com>

The only user of scsi_prep_async_scan() is scsi_scan_host() and it handles
the situation correctly. Move 'called twice' reporting to debug level as
well.

The issue is observed on Hyper-V: on any device add/remove event storvsc
driver calls scsi_scan_host() and in case previous scan is still running
we get the message and stack dump on console.

Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com>
Reviewed-by: K. Y. Srinivasan <kys@microsoft.com>
Tested-by: Alex Ng <alexng@microsoft.com>
Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
---
 drivers/scsi/scsi_scan.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/drivers/scsi/scsi_scan.c b/drivers/scsi/scsi_scan.c
index f9f3f82..01ad016 100644
--- a/drivers/scsi/scsi_scan.c
+++ b/drivers/scsi/scsi_scan.c
@@ -1712,8 +1712,7 @@ static struct async_scan_data *scsi_prep_async_scan(struct Scsi_Host *shost)
 		return NULL;
 
 	if (shost->async_scan) {
-		shost_printk(KERN_INFO, shost, "%s called twice\n", __func__);
-		dump_stack();
+		shost_printk(KERN_DEBUG, shost, "%s called twice\n", __func__);
 		return NULL;
 	}
 
-- 
1.7.4.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 0/3] scsi: Some miscellaneous fixes  "K. Y. Srinivasan" <kys@microsoft.com> - 2015-09-17 23:10 +0200
  [PATCH 2/3] scsi: introduce short_inquiry flag for broken host adapters "K. Y. Srinivasan" <kys@microsoft.com> - 2015-09-17 23:10 +0200
  [PATCH RESEND  3/3] storvsc: Don't set the SRB_FLAGS_QUEUE_ACTION_ENABLE flag "K. Y. Srinivasan" <kys@microsoft.com> - 2015-09-17 23:10 +0200
  [PATCH 1/3] scsi_scan: don't dump trace when scsi_prep_async_scan() is called twice "K. Y. Srinivasan" <kys@microsoft.com> - 2015-09-17 23:10 +0200

csiph-web