Re: tools: usbip: detach: avoid calling strlen() at each iteration

Path	csiph.com!usenet.pasdenom.info!aioe.org!bofh.it!news.nic.it!robomod
From	Aaro Koskinen <aaro.koskinen@iki.fi>
Newsgroups	linux.kernel
Subject	Re: tools: usbip: detach: avoid calling strlen() at each iteration
Date	Tue, 15 Sep 2015 23:10:01 +0200
Message-ID	<q95Ed-vd-1@gated-at.bofh.it> (permalink)
References	<q951x-7Hp-35@gated-at.bofh.it>
X-Original-To	Eric Curtin <ericcurtin17@gmail.com>
X-Greylist	delayed 320 seconds by postgrey-1.27 at vger.kernel.org; Tue, 15 Sep 2015 17:01:49 EDT
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	Mutt/1.5.23 (2014-03-12)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	35
Organization	linux.* mail to news gateway
X-Original-Cc	valentina.manea.m@gmail.com, shuah.kh@samsung.com, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
X-Original-Date	Tue, 15 Sep 2015 23:55:55 +0300
X-Original-Message-ID	<20150915205555.GA13203@blackmetal.musicnaut.iki.fi>
X-Original-References	<1442348840-32025-1-git-send-email-ericcurtin17@gmail.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1225547

Show key headers only | View raw

Hi,

On Tue, Sep 15, 2015 at 09:27:20PM +0100, Eric Curtin wrote:
> Instead of calling strlen on every iteration of the for loop, just call it
> once and cache the result in a temporary local variable which will be used
> in the for loop instead.
> 
> Signed-off-by: Eric Curtin <ericcurtin17@gmail.com>
> 
> diff --git a/tools/usb/usbip/src/usbip_detach.c b/tools/usb/usbip/src/usbip_detach.c
> index 05c6d15..9db9d21 100644
> --- a/tools/usb/usbip/src/usbip_detach.c
> +++ b/tools/usb/usbip/src/usbip_detach.c
> @@ -47,7 +47,9 @@ static int detach_port(char *port)
>  	uint8_t portnum;
>  	char path[PATH_MAX+1];
>  

The above blank line should be deleted if you declare a new local
variable below...

> -	for (unsigned int i = 0; i < strlen(port); i++)
> +	unsigned int port_len = strlen(port);
> +
> +	for (unsigned int i = 0; i < port_len; i++)

port is read only in this function, so maybe just use "const" and the
compiler should know to do the same without adding a new variable?

A.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

tools: usbip: detach: avoid calling strlen() at each iteration Eric Curtin <ericcurtin17@gmail.com> - 2015-09-15 22:30 +0200
  Re: tools: usbip: detach: avoid calling strlen() at each iteration Aaro Koskinen <aaro.koskinen@iki.fi> - 2015-09-15 23:10 +0200
    Re: tools: usbip: detach: avoid calling strlen() at each iteration Clemens Ladisch <clemens@ladisch.de> - 2015-09-16 09:40 +0200
    RE: tools: usbip: detach: avoid calling strlen() at each iteration David Laight <David.Laight@ACULAB.COM> - 2015-09-16 15:50 +0200

csiph-web