Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1225537

tools: usbip: detach: avoid calling strlen() at each iteration

Show all headers | View raw

Instead of calling strlen on every iteration of the for loop, just call it
once and cache the result in a temporary local variable which will be used
in the for loop instead.

Signed-off-by: Eric Curtin <ericcurtin17@gmail.com>

diff --git a/tools/usb/usbip/src/usbip_detach.c b/tools/usb/usbip/src/usbip_detach.c
index 05c6d15..9db9d21 100644
--- a/tools/usb/usbip/src/usbip_detach.c
+++ b/tools/usb/usbip/src/usbip_detach.c
@@ -47,7 +47,9 @@ static int detach_port(char *port)
 	uint8_t portnum;
 	char path[PATH_MAX+1];
 
-	for (unsigned int i = 0; i < strlen(port); i++)
+	unsigned int port_len = strlen(port);
+
+	for (unsigned int i = 0; i < port_len; i++)
 		if (!isdigit(port[i])) {
 			err("invalid port %s", port);
 			return -1;

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

tools: usbip: detach: avoid calling strlen() at each iteration Eric Curtin <ericcurtin17@gmail.com> - 2015-09-15 22:30 +0200
  Re: tools: usbip: detach: avoid calling strlen() at each iteration Aaro Koskinen <aaro.koskinen@iki.fi> - 2015-09-15 23:10 +0200
    Re: tools: usbip: detach: avoid calling strlen() at each iteration Clemens Ladisch <clemens@ladisch.de> - 2015-09-16 09:40 +0200
    RE: tools: usbip: detach: avoid calling strlen() at each iteration David Laight <David.Laight@ACULAB.COM> - 2015-09-16 15:50 +0200

csiph-web