Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1225538

Re: [Y2038] [PATCH 7/7] [RFC] [media] introduce v4l2_timespec type for timestamps

Show all headers | View raw

On Tuesday 15 September 2015 18:32:36 Hans Verkuil wrote:
> >  
> > -     ktime_get_ts(&timestamp);
> > +     ktime_get_ts64(&timestamp);
> > +     vts.tv_sec = timestamp.tv_sec;
> > +     vts.tv_nsec = timestamp.tv_nsec;
> 
> I prefer to take this opportunity to create a v4l2_get_timespec helper
> function, just like v4l2_get_timeval.

Ok, good idea. I'll do that once we have agreed on the ABI.

> > @@ -2088,7 +2094,7 @@ struct v4l2_event {
> >       } u;
> >       __u32                           pending;
> >       __u32                           sequence;
> > -     struct timespec                 timestamp;
> > +     struct v4l2_timespec            timestamp;
> >       __u32                           id;
> >       __u32                           reserved[8];
> >  };
> > 
> 
> I think I am OK with this. This timestamp is used much more rarely and I do
> not expect this ABI change to cause any problems in userspace.

I'd still wait the outcome of the v4l2_timeval discussion though. It may
be useful for consistency to pick the same approach for both structures.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/7] [media] y2038 conversion for subsystem Arnd Bergmann <arnd@arndb.de> - 2015-09-15 18:00 +0200
  [PATCH 5/7] [media] use v4l2_get_timestamp where possible Arnd Bergmann <arnd@arndb.de> - 2015-09-15 18:00 +0200
    Re: [PATCH 5/7] [media] use v4l2_get_timestamp where possible Sylwester Nawrocki <s.nawrocki@samsung.com> - 2015-09-16 11:00 +0200
  [PATCH 3/7] [media] dvb: don't use 'time_t' in event ioctl Arnd Bergmann <arnd@arndb.de> - 2015-09-15 18:00 +0200
  [PATCH 7/7] [RFC] [media] introduce v4l2_timespec type for timestamps Arnd Bergmann <arnd@arndb.de> - 2015-09-15 18:00 +0200
    Re: [PATCH 7/7] [RFC] [media] introduce v4l2_timespec type for timestamps Hans Verkuil <hverkuil@xs4all.nl> - 2015-09-15 18:40 +0200
      Re: [Y2038] [PATCH 7/7] [RFC] [media] introduce v4l2_timespec type for timestamps Arnd Bergmann <arnd@arndb.de> - 2015-09-15 22:30 +0200
  [PATCH 6/7] [RFC] [media]: v4l2: introduce v4l2_timeval Arnd Bergmann <arnd@arndb.de> - 2015-09-15 18:00 +0200
    Re: [PATCH 6/7] [RFC] [media]: v4l2: introduce v4l2_timeval Hans Verkuil <hverkuil@xs4all.nl> - 2015-09-15 18:30 +0200
      Re: [PATCH 6/7] [RFC] [media]: v4l2: introduce v4l2_timeval Arnd Bergmann <arnd@arndb.de> - 2015-09-15 22:30 +0200
        Re: [PATCH 6/7] [RFC] [media]: v4l2: introduce v4l2_timeval Hans Verkuil <hverkuil@xs4all.nl> - 2015-09-16 09:00 +0200
          Re: [PATCH 6/7] [RFC] [media]: v4l2: introduce v4l2_timeval Arnd Bergmann <arnd@arndb.de> - 2015-09-16 10:00 +0200
            Re: [PATCH 6/7] [RFC] [media]: v4l2: introduce v4l2_timeval Hans Verkuil <hverkuil@xs4all.nl> - 2015-09-16 10:20 +0200
              Re: [PATCH 6/7] [RFC] [media]: v4l2: introduce v4l2_timeval Arnd Bergmann <arnd@arndb.de> - 2015-09-16 10:50 +0200
  [PATCH 1/7] [media] dvb: use ktime_t for internal timeout Arnd Bergmann <arnd@arndb.de> - 2015-09-15 18:00 +0200
    Re: [PATCH 1/7] [media] dvb: use ktime_t for internal timeout Andreas Oberritter <obi@saftware.de> - 2015-09-15 20:10 +0200
      Re: [Y2038] [PATCH 1/7] [media] dvb: use ktime_t for internal timeout Arnd Bergmann <arnd@arndb.de> - 2015-09-15 22:40 +0200
  [PATCH 2/7] [media] dvb: remove unused systime() function Arnd Bergmann <arnd@arndb.de> - 2015-09-15 18:00 +0200

csiph-web