Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1223988

Re: [PATCH] x86, perf, uncore: Don't make MSR uncore depend on PCI uncore

Show all headers | View raw

On Wed, 9 Sep 2015, Andi Kleen wrote:
> --- a/arch/x86/kernel/cpu/perf_event_intel_uncore.c
> +++ b/arch/x86/kernel/cpu/perf_event_intel_uncore.c
> @@ -958,6 +958,8 @@ static void __init uncore_pci_exit(void)
>  		uncore_types_exit(uncore_pci_uncores);
>  	}
>  }
> +module_exit(uncore_pci_exit);
> +/* XXX: need exit code for rest of intel_uncore_init too */

That comment makes no sense at all.
  
Other than that:

Reviewed-by: Thomas Gleixner <tglx@linutronix.de>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] x86, perf, uncore: Don't make MSR uncore depend on PCI uncore Andi Kleen <andi@firstfloor.org> - 2015-09-10 00:10 +0200
  Re: [PATCH] x86, perf, uncore: Don't make MSR uncore depend on PCI  uncore Thomas Gleixner <tglx@linutronix.de> - 2015-09-14 11:50 +0200

csiph-web