Re: [PATCH v7 2/8] ARM64: add SBSA Generic Watchdog device node in foundation-v8.dts

Path	csiph.com!goblin2!goblin3!goblin1!goblin.stu.neva.ru!newsfeed.CARNet.hr!news.spin.it!bofh.it!news.nic.it!robomod
From	Fu Wei <fu.wei@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v7 2/8] ARM64: add SBSA Generic Watchdog device node in foundation-v8.dts
Date	Tue, 15 Sep 2015 12:20:01 +0200
Message-ID	<q8Vvb-1PR-7@gated-at.bofh.it> (permalink)
References	<pqlF8-659-23@gated-at.bofh.it> <q13pU-5xE-5@gated-at.bofh.it> <q13pW-5xE-47@gated-at.bofh.it> <q8U66-86T-19@gated-at.bofh.it>
X-Original-To	Dave Young <dyoung@redhat.com>
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=7ukfeSa28ru8X+fFiP9S2VEOO8L0/CHgpyCD8Cv+aCo=; b=AOTcKBew9/HrY+FwSL1npRp7L1dH1dYUc95zRanY4kGDD3Cqnm8z/dIgVw5fJKZ17t krxftsQDUsXy9KS1Jx4ftEMGKLL1WsBv2JzFIKQPgsNIcgtz6sLZStDlSJDTokt5nXmi n/CI99bWGoAoR19XNztNJ0yesqRgG69hcrg7l45YxcgJQ6bNJF6ZExIMuEO5d7SAHMpm 3bwmxuGJCuu4DRpvqyahE8Hp6G+O4WWBZ1igM26GJKB4orM7YY9kzFJB3NJhtV5w5W8R Nnu+c6RIx5PDfHcqZMmRZjmTeig+WhYMKIYbKc/KsuWZpx60Z2ePxT4/zjTI7gGbFUC2 +rVA==
X-Gm-Message-State	ALoCoQkPcp5XiuoMdro9KEX8y+lhQ7PE+BGsQaxKlgiv+EABTG68fbo8p7IonrtkhoBgmdaqWCjz
MIME-Version	1.0
X-Received	by 10.202.221.198 with SMTP id u189mr15450337oig.68.1442312150310; Tue, 15 Sep 2015 03:15:50 -0700 (PDT)
Content-Type	text/plain; charset=UTF-8
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	70
Organization	linux.* mail to news gateway
X-Original-Cc	Suravee Suthikulpanit <Suravee.Suthikulpanit@amd.com>, Hanjun Guo <hanjun.guo@linaro.org>, Linaro ACPI Mailman List <linaro-acpi@lists.linaro.org>, linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>, linux-doc@vger.kernel.org, Wei Fu <tekkamanninja@gmail.com>, G Gregory <graeme.gregory@linaro.org>, Al Stone <al.stone@linaro.org>, Arnd Bergmann <arnd@arndb.de>, Guenter Roeck <linux@roeck-us.net>, Vipul Gandhi <vgandhi@codeaurora.org>, Wim Van Sebroeck <wim@iguana.be>, Jon Masters <jcm@redhat.com>, Leo Duran <leo.duran@amd.com>, Jon Corbet <corbet@lwn.net>, Mark Rutland <mark.rutland@arm.com>, Catalin Marinas <catalin.marinas@arm.com>, Will Deacon <will.deacon@arm.com>, Rafael Wysocki <rjw@rjwysocki.net>, Pratyush Anand <panand@redhat.com>
X-Original-Date	Tue, 15 Sep 2015 18:15:50 +0800
X-Original-Message-ID	<CADyBb7vB9Mv1YApY0H3+wkapn6agQJTs46ap4BHaOyYmLh+pLg@mail.gmail.com>
X-Original-References	<=fu.wei@linaro.org> <1440435683-7343-1-git-send-email-fu.wei@linaro.org> <1440435683-7343-3-git-send-email-fu.wei@linaro.org> <20150915084332.GC5767@localhost.localdomain>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1224974

Show key headers only | View raw

Hi Dave,

On 15 September 2015 at 16:43, Dave Young <dyoung@redhat.com> wrote:
> On 08/25/15 at 01:01am, fu.wei@linaro.org wrote:
>> From: Fu Wei <fu.wei@linaro.org>
>>
>> This can be a example of adding SBSA Generic Watchdog device node
>> into some dts files for the Soc which contains SBSA Generic Watchdog.
>>
>> Acked-by: Arnd Bergmann <arnd@arndb.de>
>> Signed-off-by: Fu Wei <fu.wei@linaro.org>
>> ---
>>  arch/arm64/boot/dts/arm/foundation-v8.dts | 7 +++++++
>>  1 file changed, 7 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/arm/foundation-v8.dts b/arch/arm64/boot/dts/arm/foundation-v8.dts
>> index 4eac8dc..824431f 100644
>> --- a/arch/arm64/boot/dts/arm/foundation-v8.dts
>> +++ b/arch/arm64/boot/dts/arm/foundation-v8.dts
>> @@ -237,4 +237,11 @@
>>                       };
>>               };
>>       };
>> +     watchdog@2a440000 {
>> +             compatible = "arm,sbsa-gwdt";
>> +             reg = <0x0 0x2a440000 0 0x1000>,
>> +                     <0x0 0x2a450000 0 0x1000>;
>> +             interrupts = <0 27 4>;
>> +             timeout-sec = <10 5>;
>
> I assume 10 is timeout, 5 is pre timeout, but in the driver code the default
> value is 30/10, I think the example dts[i] should use same default values as in code.

yes, that is good idea, will make them to be the same.  :-)

>
> BTW, for kdump kernel Pratyush is working on kdump on wdt enabled system.
> Basiclly we expect one configure longer timeout, and kick it in shorter
> period so we can get a chance to save vmcore. 10s sounds too short for the case..

Thanks for your info.

So that means: we may need that long timeout support in the second stage.
WOR is not enough for  the second stage in most of kdump case.

>
>> +     };
>>  };
>> --
>> 2.4.3
>>



-- 
Best regards,

Fu Wei
Software Engineer
Red Hat Software (Beijing) Co.,Ltd.Shanghai Branch
Ph: +86 21 61221326(direct)
Ph: +86 186 2020 4684 (mobile)
Room 1512, Regus One Corporate Avenue,Level 15,
One Corporate Avenue,222 Hubin Road,Huangpu District,
Shanghai,China 200021
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v7 2/8] ARM64: add SBSA Generic Watchdog device node in  foundation-v8.dts Dave Young <dyoung@redhat.com> - 2015-09-15 10:50 +0200
  Re: [PATCH v7 2/8] ARM64: add SBSA Generic Watchdog device node in  foundation-v8.dts Pratyush Anand <panand@redhat.com> - 2015-09-15 11:50 +0200
    Re: [PATCH v7 2/8] ARM64: add SBSA Generic Watchdog device node in foundation-v8.dts Fu Wei <fu.wei@linaro.org> - 2015-09-15 12:30 +0200
  Re: [PATCH v7 2/8] ARM64: add SBSA Generic Watchdog device node in foundation-v8.dts Fu Wei <fu.wei@linaro.org> - 2015-09-15 12:20 +0200

csiph-web