Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1224773 > unrolled thread
| Started by | Dave Young <dyoung@redhat.com> |
|---|---|
| First post | 2015-09-15 10:50 +0200 |
| Last post | 2015-09-15 12:20 +0200 |
| Articles | 4 — 3 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH v7 2/8] ARM64: add SBSA Generic Watchdog device node in foundation-v8.dts Dave Young <dyoung@redhat.com> - 2015-09-15 10:50 +0200
Re: [PATCH v7 2/8] ARM64: add SBSA Generic Watchdog device node in foundation-v8.dts Pratyush Anand <panand@redhat.com> - 2015-09-15 11:50 +0200
Re: [PATCH v7 2/8] ARM64: add SBSA Generic Watchdog device node in foundation-v8.dts Fu Wei <fu.wei@linaro.org> - 2015-09-15 12:30 +0200
Re: [PATCH v7 2/8] ARM64: add SBSA Generic Watchdog device node in foundation-v8.dts Fu Wei <fu.wei@linaro.org> - 2015-09-15 12:20 +0200
| From | Dave Young <dyoung@redhat.com> |
|---|---|
| Date | 2015-09-15 10:50 +0200 |
| Subject | Re: [PATCH v7 2/8] ARM64: add SBSA Generic Watchdog device node in foundation-v8.dts |
| Message-ID | <q8U66-86T-19@gated-at.bofh.it> |
On 08/25/15 at 01:01am, fu.wei@linaro.org wrote:
> From: Fu Wei <fu.wei@linaro.org>
>
> This can be a example of adding SBSA Generic Watchdog device node
> into some dts files for the Soc which contains SBSA Generic Watchdog.
>
> Acked-by: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: Fu Wei <fu.wei@linaro.org>
> ---
> arch/arm64/boot/dts/arm/foundation-v8.dts | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/arm/foundation-v8.dts b/arch/arm64/boot/dts/arm/foundation-v8.dts
> index 4eac8dc..824431f 100644
> --- a/arch/arm64/boot/dts/arm/foundation-v8.dts
> +++ b/arch/arm64/boot/dts/arm/foundation-v8.dts
> @@ -237,4 +237,11 @@
> };
> };
> };
> + watchdog@2a440000 {
> + compatible = "arm,sbsa-gwdt";
> + reg = <0x0 0x2a440000 0 0x1000>,
> + <0x0 0x2a450000 0 0x1000>;
> + interrupts = <0 27 4>;
> + timeout-sec = <10 5>;
I assume 10 is timeout, 5 is pre timeout, but in the driver code the default
value is 30/10, I think the example dts[i] should use same default values as in code.
BTW, for kdump kernel Pratyush is working on kdump on wdt enabled system.
Basiclly we expect one configure longer timeout, and kick it in shorter
period so we can get a chance to save vmcore. 10s sounds too short for the case..
> + };
> };
> --
> 2.4.3
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Pratyush Anand <panand@redhat.com> |
|---|---|
| Date | 2015-09-15 11:50 +0200 |
| Message-ID | <q8V2a-12p-15@gated-at.bofh.it> |
| In reply to | #1224773 |
On 15/09/2015:04:43:32 PM, Dave Young wrote:
> On 08/25/15 at 01:01am, fu.wei@linaro.org wrote:
> > From: Fu Wei <fu.wei@linaro.org>
> >
> > This can be a example of adding SBSA Generic Watchdog device node
> > into some dts files for the Soc which contains SBSA Generic Watchdog.
> >
> > Acked-by: Arnd Bergmann <arnd@arndb.de>
> > Signed-off-by: Fu Wei <fu.wei@linaro.org>
> > ---
> > arch/arm64/boot/dts/arm/foundation-v8.dts | 7 +++++++
> > 1 file changed, 7 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/arm/foundation-v8.dts b/arch/arm64/boot/dts/arm/foundation-v8.dts
> > index 4eac8dc..824431f 100644
> > --- a/arch/arm64/boot/dts/arm/foundation-v8.dts
> > +++ b/arch/arm64/boot/dts/arm/foundation-v8.dts
> > @@ -237,4 +237,11 @@
> > };
> > };
> > };
> > + watchdog@2a440000 {
> > + compatible = "arm,sbsa-gwdt";
> > + reg = <0x0 0x2a440000 0 0x1000>,
> > + <0x0 0x2a450000 0 0x1000>;
> > + interrupts = <0 27 4>;
> > + timeout-sec = <10 5>;
>
> I assume 10 is timeout, 5 is pre timeout, but in the driver code the default
> value is 30/10, I think the example dts[i] should use same default values as in code.
>
> BTW, for kdump kernel Pratyush is working on kdump on wdt enabled system.
> Basiclly we expect one configure longer timeout, and kick it in shorter
> period so we can get a chance to save vmcore. 10s sounds too short for the case..
Specially if D-cache is not enabled in ARM64 kexec-tool/purgatory then its more
than 2 min. Geoff has yet not agreed [1] to take D-cache support in purgatory.
[1] https://www.mail-archive.com/kexec@lists.infradead.org/msg12881.html
~Pratyush
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Fu Wei <fu.wei@linaro.org> |
|---|---|
| Date | 2015-09-15 12:30 +0200 |
| Subject | Re: [PATCH v7 2/8] ARM64: add SBSA Generic Watchdog device node in foundation-v8.dts |
| Message-ID | <q8VER-21d-11@gated-at.bofh.it> |
| In reply to | #1224923 |
Hi Pratyush,
On 15 September 2015 at 17:44, Pratyush Anand <panand@redhat.com> wrote:
> On 15/09/2015:04:43:32 PM, Dave Young wrote:
>> On 08/25/15 at 01:01am, fu.wei@linaro.org wrote:
>> > From: Fu Wei <fu.wei@linaro.org>
>> >
>> > This can be a example of adding SBSA Generic Watchdog device node
>> > into some dts files for the Soc which contains SBSA Generic Watchdog.
>> >
>> > Acked-by: Arnd Bergmann <arnd@arndb.de>
>> > Signed-off-by: Fu Wei <fu.wei@linaro.org>
>> > ---
>> > arch/arm64/boot/dts/arm/foundation-v8.dts | 7 +++++++
>> > 1 file changed, 7 insertions(+)
>> >
>> > diff --git a/arch/arm64/boot/dts/arm/foundation-v8.dts b/arch/arm64/boot/dts/arm/foundation-v8.dts
>> > index 4eac8dc..824431f 100644
>> > --- a/arch/arm64/boot/dts/arm/foundation-v8.dts
>> > +++ b/arch/arm64/boot/dts/arm/foundation-v8.dts
>> > @@ -237,4 +237,11 @@
>> > };
>> > };
>> > };
>> > + watchdog@2a440000 {
>> > + compatible = "arm,sbsa-gwdt";
>> > + reg = <0x0 0x2a440000 0 0x1000>,
>> > + <0x0 0x2a450000 0 0x1000>;
>> > + interrupts = <0 27 4>;
>> > + timeout-sec = <10 5>;
>>
>> I assume 10 is timeout, 5 is pre timeout, but in the driver code the default
>> value is 30/10, I think the example dts[i] should use same default values as in code.
>>
>> BTW, for kdump kernel Pratyush is working on kdump on wdt enabled system.
>> Basiclly we expect one configure longer timeout, and kick it in shorter
>> period so we can get a chance to save vmcore. 10s sounds too short for the case..
>
> Specially if D-cache is not enabled in ARM64 kexec-tool/purgatory then its more
> than 2 min. Geoff has yet not agreed [1] to take D-cache support in purgatory.
>
> [1] https://www.mail-archive.com/kexec@lists.infradead.org/msg12881.html
Great thanks for your info.
I thinks I may need to make the default pretimeout longer in example,
may be at least 30s(for kdump kernel with D-cache)
any thought?
>
> ~Pratyush
--
Best regards,
Fu Wei
Software Engineer
Red Hat Software (Beijing) Co.,Ltd.Shanghai Branch
Ph: +86 21 61221326(direct)
Ph: +86 186 2020 4684 (mobile)
Room 1512, Regus One Corporate Avenue,Level 15,
One Corporate Avenue,222 Hubin Road,Huangpu District,
Shanghai,China 200021
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Fu Wei <fu.wei@linaro.org> |
|---|---|
| Date | 2015-09-15 12:20 +0200 |
| Subject | Re: [PATCH v7 2/8] ARM64: add SBSA Generic Watchdog device node in foundation-v8.dts |
| Message-ID | <q8Vvb-1PR-7@gated-at.bofh.it> |
| In reply to | #1224773 |
Hi Dave,
On 15 September 2015 at 16:43, Dave Young <dyoung@redhat.com> wrote:
> On 08/25/15 at 01:01am, fu.wei@linaro.org wrote:
>> From: Fu Wei <fu.wei@linaro.org>
>>
>> This can be a example of adding SBSA Generic Watchdog device node
>> into some dts files for the Soc which contains SBSA Generic Watchdog.
>>
>> Acked-by: Arnd Bergmann <arnd@arndb.de>
>> Signed-off-by: Fu Wei <fu.wei@linaro.org>
>> ---
>> arch/arm64/boot/dts/arm/foundation-v8.dts | 7 +++++++
>> 1 file changed, 7 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/arm/foundation-v8.dts b/arch/arm64/boot/dts/arm/foundation-v8.dts
>> index 4eac8dc..824431f 100644
>> --- a/arch/arm64/boot/dts/arm/foundation-v8.dts
>> +++ b/arch/arm64/boot/dts/arm/foundation-v8.dts
>> @@ -237,4 +237,11 @@
>> };
>> };
>> };
>> + watchdog@2a440000 {
>> + compatible = "arm,sbsa-gwdt";
>> + reg = <0x0 0x2a440000 0 0x1000>,
>> + <0x0 0x2a450000 0 0x1000>;
>> + interrupts = <0 27 4>;
>> + timeout-sec = <10 5>;
>
> I assume 10 is timeout, 5 is pre timeout, but in the driver code the default
> value is 30/10, I think the example dts[i] should use same default values as in code.
yes, that is good idea, will make them to be the same. :-)
>
> BTW, for kdump kernel Pratyush is working on kdump on wdt enabled system.
> Basiclly we expect one configure longer timeout, and kick it in shorter
> period so we can get a chance to save vmcore. 10s sounds too short for the case..
Thanks for your info.
So that means: we may need that long timeout support in the second stage.
WOR is not enough for the second stage in most of kdump case.
>
>> + };
>> };
>> --
>> 2.4.3
>>
--
Best regards,
Fu Wei
Software Engineer
Red Hat Software (Beijing) Co.,Ltd.Shanghai Branch
Ph: +86 21 61221326(direct)
Ph: +86 186 2020 4684 (mobile)
Room 1512, Regus One Corporate Avenue,Level 15,
One Corporate Avenue,222 Hubin Road,Huangpu District,
Shanghai,China 200021
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web