Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1224767
| From | Laurentiu Palcu <laurentiu.palcu@intel.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v4 2/7] power: bq27x00_battery: Renaming for consistency |
| Date | 2015-09-15 10:40 +0200 |
| Message-ID | <q8TWr-7VB-33@gated-at.bofh.it> (permalink) |
| References | <q8Ju1-1pD-9@gated-at.bofh.it> <q8Ju2-1pD-39@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Mon, Sep 14, 2015 at 04:26:08PM -0500, Andrew F. Davis wrote:
> Rename functions that are used by multiple devices. New devices
> have been added and the function names and driver name are no longer
> general enough for the functionality they provide.
>
> Signed-off-by: Andrew F. Davis <afd@ti.com>
> ---
> MAINTAINERS | 4 +-
> arch/arm/configs/omap2plus_defconfig | 2 +-
> arch/unicore32/Kconfig | 2 +-
> drivers/power/Kconfig | 22 +-
> drivers/power/Makefile | 2 +-
> .../power/{bq27x00_battery.c => bq27xxx_battery.c} | 333 +++++++++++----------
1000 chips! That's how many potential chips is this driver supposed to
support, after the rename, with little or no modifications. Is it even
possible to guarantee that all future chips, starting with 'bq27' in
their naming scheme, are register compatible?
Call me conservative, but when I see driver names/renames containing
wildcards, I get chills down my spine. I can probably get over single
digit wildcards but 3 digit wildcards is a little too much. :)
I can't help but wonder what will one have to do if one single newly
released bq27xxx chip is completely different... :/
laurentiu
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v4 0/7] Add support for additional bq27xxx devices "Andrew F. Davis" <afd@ti.com> - 2015-09-14 23:30 +0200
[PATCH v4 6/7] power: bq27xxx_battery: Cleanup health checking "Andrew F. Davis" <afd@ti.com> - 2015-09-14 23:30 +0200
Re: [PATCH v4 6/7] power: bq27xxx_battery: Cleanup health checking Pali Rohár <pali.rohar@gmail.com> - 2015-09-21 10:40 +0200
[PATCH v4 1/7] power: bq27x00_battery: Remove unneeded i2c MODULE_ALIAS "Andrew F. Davis" <afd@ti.com> - 2015-09-14 23:30 +0200
Re: [PATCH v4 1/7] power: bq27x00_battery: Remove unneeded i2c MODULE_ALIAS Pali Rohár <pali.rohar@gmail.com> - 2015-09-21 10:40 +0200
[PATCH v4 3/7] power: bq27xxx_battery: Platform initialization must declare a device "Andrew F. Davis" <afd@ti.com> - 2015-09-14 23:30 +0200
Re: [PATCH v4 3/7] power: bq27xxx_battery: Platform initialization must declare a device Pali Rohár <pali.rohar@gmail.com> - 2015-09-21 10:50 +0200
Re: [PATCH v4 3/7] power: bq27xxx_battery: Platform initialization must declare a device "Andrew F. Davis" <afd@ti.com> - 2015-09-21 20:50 +0200
[PATCH v4 4/7] power: bq27xxx_battery: Fix typos and change naming for state of charge functions "Andrew F. Davis" <afd@ti.com> - 2015-09-14 23:30 +0200
Re: [PATCH v4 4/7] power: bq27xxx_battery: Fix typos and change naming for state of charge functions Pali Rohár <pali.rohar@gmail.com> - 2015-09-21 10:40 +0200
[PATCH v4 7/7] power: bq27xxx_battery: Add interrupt handling support "Andrew F. Davis" <afd@ti.com> - 2015-09-14 23:30 +0200
Re: [PATCH v4 7/7] power: bq27xxx_battery: Add interrupt handling support Andreas Dannenberg <dannenberg@ti.com> - 2015-09-15 20:50 +0200
Re: [PATCH v4 7/7] power: bq27xxx_battery: Add interrupt handling support "Andrew F. Davis" <afd@ti.com> - 2015-09-15 23:00 +0200
[PATCH v4 5/7] power: bq27xxx_battery: Add support for additional bq27xxx family devices "Andrew F. Davis" <afd@ti.com> - 2015-09-14 23:30 +0200
Re: [PATCH v4 5/7] power: bq27xxx_battery: Add support for additional bq27xxx family devices Pali Rohár <pali.rohar@gmail.com> - 2015-09-21 10:50 +0200
Re: [PATCH v4 5/7] power: bq27xxx_battery: Add support for additional bq27xxx family devices "Andrew F. Davis" <afd@ti.com> - 2015-09-21 21:10 +0200
[PATCH v4 2/7] power: bq27x00_battery: Renaming for consistency "Andrew F. Davis" <afd@ti.com> - 2015-09-14 23:30 +0200
Re: [PATCH v4 2/7] power: bq27x00_battery: Renaming for consistency Laurentiu Palcu <laurentiu.palcu@intel.com> - 2015-09-15 10:40 +0200
Re: [PATCH v4 2/7] power: bq27x00_battery: Renaming for consistency "Andrew F. Davis" <afd@ti.com> - 2015-09-15 19:00 +0200
csiph-web