Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1224464

[PATCH v4 3/7] power: bq27xxx_battery: Platform initialization must declare a device

Show all headers | View raw

When initialized as a platform device the initializer must now specify
a device. An empty device name is no longer valid.

Signed-off-by: Andrew F. Davis <afd@ti.com>
---
 drivers/power/bq27xxx_battery.c       | 9 ++++++---
 drivers/w1/slaves/w1_bq27000.c        | 1 +
 include/linux/power/bq27xxx_battery.h | 6 +++++-
 3 files changed, 12 insertions(+), 4 deletions(-)

diff --git a/drivers/power/bq27xxx_battery.c b/drivers/power/bq27xxx_battery.c
index e72055c..0734413 100644
--- a/drivers/power/bq27xxx_battery.c
+++ b/drivers/power/bq27xxx_battery.c
@@ -91,8 +91,6 @@ struct bq27xxx_access_methods {
 	int (*read)(struct bq27xxx_device_info *di, u8 reg, bool single);
 };
 
-enum bq27xxx_chip { BQ27000, BQ27500, BQ27425, BQ27742, BQ27510};
-
 struct bq27xxx_reg_cache {
 	int temperature;
 	int time_to_empty;
@@ -1036,6 +1034,11 @@ static int bq27xxx_battery_platform_probe(struct platform_device *pdev)
 		return -EINVAL;
 	}
 
+	if (!pdata->chip) {
+		dev_err(&pdev->dev, "no device supplied\n");
+		return -EINVAL;
+	}
+
 	di = devm_kzalloc(&pdev->dev, sizeof(*di), GFP_KERNEL);
 	if (!di)
 		return -ENOMEM;
@@ -1043,7 +1046,7 @@ static int bq27xxx_battery_platform_probe(struct platform_device *pdev)
 	platform_set_drvdata(pdev, di);
 
 	di->dev = &pdev->dev;
-	di->chip = BQ27000;
+	di->chip = pdata->chip;
 
 	name = pdata->name ?: dev_name(&pdev->dev);
 	di->bus.read = &bq27xxx_battery_platform_read;
diff --git a/drivers/w1/slaves/w1_bq27000.c b/drivers/w1/slaves/w1_bq27000.c
index 8480531..9f4a86b 100644
--- a/drivers/w1/slaves/w1_bq27000.c
+++ b/drivers/w1/slaves/w1_bq27000.c
@@ -42,6 +42,7 @@ static int w1_bq27000_read(struct device *dev, unsigned int reg)
 static struct bq27xxx_platform_data bq27000_battery_info = {
 	.read   = w1_bq27000_read,
 	.name   = "bq27000-battery",
+	.chip   = BQ27000,
 };
 
 static int w1_bq27000_add_slave(struct w1_slave *sl)
diff --git a/include/linux/power/bq27xxx_battery.h b/include/linux/power/bq27xxx_battery.h
index e70a93a..a4efb10 100644
--- a/include/linux/power/bq27xxx_battery.h
+++ b/include/linux/power/bq27xxx_battery.h
@@ -3,7 +3,8 @@
 
 /**
  * struct bq27xxx_plaform_data - Platform data for bq27xxx devices
- * @name: Name of the battery. If NULL the driver will fallback to "bq27000".
+ * @name: Name of the battery.
+ * @chip: Chip class number of this device.
  * @read: HDQ read callback.
  *	This function should provide access to the HDQ bus the battery is
  *	connected to.
@@ -11,8 +12,11 @@
  *	register to be read. The return value should either be the content of
  *	the passed register or an error value.
  */
+enum bq27xxx_chip { BQ27000 = 1, BQ27500, BQ27425, BQ27742, BQ27510 };
+
 struct bq27xxx_platform_data {
 	const char *name;
+	enum bq27xxx_chip chip;
 	int (*read)(struct device *dev, unsigned int);
 };
 
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v4 0/7] Add support for additional bq27xxx devices "Andrew F. Davis" <afd@ti.com> - 2015-09-14 23:30 +0200
  [PATCH v4 6/7] power: bq27xxx_battery: Cleanup health checking "Andrew F. Davis" <afd@ti.com> - 2015-09-14 23:30 +0200
    Re: [PATCH v4 6/7] power: bq27xxx_battery: Cleanup health checking Pali Rohár <pali.rohar@gmail.com> - 2015-09-21 10:40 +0200
  [PATCH v4 1/7] power: bq27x00_battery: Remove unneeded i2c MODULE_ALIAS "Andrew F. Davis" <afd@ti.com> - 2015-09-14 23:30 +0200
    Re: [PATCH v4 1/7] power: bq27x00_battery: Remove unneeded i2c  MODULE_ALIAS Pali Rohár <pali.rohar@gmail.com> - 2015-09-21 10:40 +0200
  [PATCH v4 3/7] power: bq27xxx_battery: Platform initialization must declare a device "Andrew F. Davis" <afd@ti.com> - 2015-09-14 23:30 +0200
    Re: [PATCH v4 3/7] power: bq27xxx_battery: Platform initialization  must declare a device Pali Rohár <pali.rohar@gmail.com> - 2015-09-21 10:50 +0200
      Re: [PATCH v4 3/7] power: bq27xxx_battery: Platform initialization  must declare a device "Andrew F. Davis" <afd@ti.com> - 2015-09-21 20:50 +0200
  [PATCH v4 4/7] power: bq27xxx_battery: Fix typos and change naming for state of charge functions "Andrew F. Davis" <afd@ti.com> - 2015-09-14 23:30 +0200
    Re: [PATCH v4 4/7] power: bq27xxx_battery: Fix typos and change  naming for state of charge functions Pali Rohár <pali.rohar@gmail.com> - 2015-09-21 10:40 +0200
  [PATCH v4 7/7] power: bq27xxx_battery: Add interrupt handling support "Andrew F. Davis" <afd@ti.com> - 2015-09-14 23:30 +0200
    Re: [PATCH v4 7/7] power: bq27xxx_battery: Add interrupt handling  support Andreas Dannenberg <dannenberg@ti.com> - 2015-09-15 20:50 +0200
      Re: [PATCH v4 7/7] power: bq27xxx_battery: Add interrupt handling  support "Andrew F. Davis" <afd@ti.com> - 2015-09-15 23:00 +0200
  [PATCH v4 5/7] power: bq27xxx_battery: Add support for additional bq27xxx family devices "Andrew F. Davis" <afd@ti.com> - 2015-09-14 23:30 +0200
    Re: [PATCH v4 5/7] power: bq27xxx_battery: Add support for  additional bq27xxx family devices Pali Rohár <pali.rohar@gmail.com> - 2015-09-21 10:50 +0200
      Re: [PATCH v4 5/7] power: bq27xxx_battery: Add support for additional  bq27xxx family devices "Andrew F. Davis" <afd@ti.com> - 2015-09-21 21:10 +0200
  [PATCH v4 2/7] power: bq27x00_battery: Renaming for consistency "Andrew F. Davis" <afd@ti.com> - 2015-09-14 23:30 +0200
    Re: [PATCH v4 2/7] power: bq27x00_battery: Renaming for consistency Laurentiu Palcu <laurentiu.palcu@intel.com> - 2015-09-15 10:40 +0200
      Re: [PATCH v4 2/7] power: bq27x00_battery: Renaming for consistency "Andrew F. Davis" <afd@ti.com> - 2015-09-15 19:00 +0200

csiph-web