Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1224149
| From | Punit Agrawal <punit.agrawal@arm.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v3 1/5] Documentation: add DT bindings for ARM SCPI sensors |
| Date | 2015-09-14 15:40 +0200 |
| Message-ID | <q8C9c-7DX-13@gated-at.bofh.it> (permalink) |
| References | <q8BGa-75S-11@gated-at.bofh.it> <q8BGb-75S-55@gated-at.bofh.it> <q8BPQ-7hh-29@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Hi Mark,
Thanks for taking a look.
Mark Rutland <mark.rutland@arm.com> writes:
> On Mon, Sep 14, 2015 at 02:00:14PM +0100, Punit Agrawal wrote:
>> The System Control Processor (SCP) provides access to SoC sensors via
>> the System Control and Power Interface (SCPI) Message Protocol. Add
>> bindings to allow probing of these sensors. Also support referencing
>> of the sensors for setting up thermal zones via the thermal DT
>> bindings.
>>
>> Signed-off-by: Punit Agrawal <punit.agrawal@arm.com>
>> Cc: Rob Herring <robh+dt@kernel.org>
>> Cc: Mark Rutland <mark.rutland@arm.com>
>> Cc: Sudeep Holla <sudeep.holla@arm.com>
>> ---
>> Documentation/devicetree/bindings/arm/arm,scpi.txt | 15 +++++++++++++++
>> 1 file changed, 15 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/arm/arm,scpi.txt b/Documentation/devicetree/bindings/arm/arm,scpi.txt
>> index f002460..af66f7f 100644
>> --- a/Documentation/devicetree/bindings/arm/arm,scpi.txt
>> +++ b/Documentation/devicetree/bindings/arm/arm,scpi.txt
>> @@ -72,8 +72,18 @@ Required sub-node properties:
>> - compatible : should be "arm,juno-scp-shmem" for Non-secure SRAM based
>> shared memory on Juno platforms
>>
>> +Sensor bindings for the sensors based on SCPI Message Protocol
>> +--------------------------------------------------------------
>> +SCPI provides an API to access the various sensors on the SoC.
>> +
>> +Required properties:
>> +- compatible : should be "arm,scpi-sensors".
>> +- #thermal-sensor-cells: should be set to 1. This property follows the
>> + thermal device tree bindings[2].
>
> You need to specify what the valid values for this cell are.
The enumeration depends on the number of sensors exported by SCP
firmware - which is platform dependent. I could add add something like
if you think that is helpful -
"Valid cell value is a number between 0..n-1, where n is the number
of sensors exported by SCP firmware."
Thanks,
Punit
>
> Mark.
>
>> +
>> [0] http://infocenter.arm.com/help/topic/com.arm.doc.dui0922b/index.html
>> [1] Documentation/devicetree/bindings/clock/clock-bindings.txt
>> +[2] Documentation/devicetree/bindings/thermal/thermal.txt
>>
>> Example:
>>
>> @@ -122,6 +132,11 @@ scpi_protocol: scpi@2e000000 {
>> clock-output-names = "pxlclk0", "pxlclk1";
>> };
>> };
>> +
>> + scpi_sensors0: sensors {
>> + compatible = "arm,scpi-sensors";
>> + #thermal-sensor-cells = <1>;
>> + };
>> };
>>
>> cpu@0 {
>> --
>> 2.5.0
>>
> --
> To unsubscribe from this list: send the line "unsubscribe devicetree" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v3 0/5] SCPI Sensor support Punit Agrawal <punit.agrawal@arm.com> - 2015-09-14 15:10 +0200
[PATCH v3 3/5] hwmon: Support sensors exported via ARM SCP interface Punit Agrawal <punit.agrawal@arm.com> - 2015-09-14 15:10 +0200
[PATCH v3 1/5] Documentation: add DT bindings for ARM SCPI sensors Punit Agrawal <punit.agrawal@arm.com> - 2015-09-14 15:10 +0200
Re: [PATCH v3 1/5] Documentation: add DT bindings for ARM SCPI sensors Mark Rutland <mark.rutland@arm.com> - 2015-09-14 15:20 +0200
Re: [PATCH v3 1/5] Documentation: add DT bindings for ARM SCPI sensors Punit Agrawal <punit.agrawal@arm.com> - 2015-09-14 15:40 +0200
Re: [PATCH v3 1/5] Documentation: add DT bindings for ARM SCPI sensors Mark Rutland <mark.rutland@arm.com> - 2015-09-14 16:00 +0200
Re: [PATCH v3 1/5] Documentation: add DT bindings for ARM SCPI sensors Punit Agrawal <punit.agrawal@arm.com> - 2015-09-14 16:40 +0200
Re: [PATCH v3 1/5] Documentation: add DT bindings for ARM SCPI sensors Mark Rutland <mark.rutland@arm.com> - 2015-09-14 16:50 +0200
Re: [PATCH v3 1/5] Documentation: add DT bindings for ARM SCPI sensors Punit Agrawal <punit.agrawal@arm.com> - 2015-09-14 17:10 +0200
Re: [PATCH v3 1/5] Documentation: add DT bindings for ARM SCPI sensors Mark Rutland <mark.rutland@arm.com> - 2015-09-14 17:20 +0200
Re: [PATCH v3 1/5] Documentation: add DT bindings for ARM SCPI sensors Punit Agrawal <punit.agrawal@arm.com> - 2015-09-14 18:10 +0200
Re: [PATCH v3 1/5] Documentation: add DT bindings for ARM SCPI sensors "Jon Medhurst (Tixy)" <tixy@linaro.org> - 2015-09-14 20:20 +0200
Re: [PATCH v3 1/5] Documentation: add DT bindings for ARM SCPI sensors Punit Agrawal <punit.agrawal@arm.com> - 2015-09-15 11:40 +0200
Re: [PATCH v3 1/5] Documentation: add DT bindings for ARM SCPI sensors "Jon Medhurst (Tixy)" <tixy@linaro.org> - 2015-09-15 12:50 +0200
Re: [PATCH v3 1/5] Documentation: add DT bindings for ARM SCPI sensors Mark Rutland <mark.rutland@arm.com> - 2015-09-15 13:10 +0200
Re: [PATCH v3 1/5] Documentation: add DT bindings for ARM SCPI sensors "Jon Medhurst (Tixy)" <tixy@linaro.org> - 2015-09-15 13:40 +0200
Re: [PATCH v3 1/5] Documentation: add DT bindings for ARM SCPI sensors Punit Agrawal <punit.agrawal@arm.com> - 2015-09-15 18:10 +0200
Re: [PATCH v3 1/5] Documentation: add DT bindings for ARM SCPI sensors "Jon Medhurst (Tixy)" <tixy@linaro.org> - 2015-09-15 18:40 +0200
[PATCH v3 5/5] arm64: dts: Add sensor node to Juno dt Punit Agrawal <punit.agrawal@arm.com> - 2015-09-14 15:20 +0200
[PATCH v3 4/5] hwmon: Support thermal zones registration for SCP temperature sensors Punit Agrawal <punit.agrawal@arm.com> - 2015-09-14 15:20 +0200
[Patch v3 4/5] hwmon: Support registration of thermal zones for SCP temperature sensors Punit Agrawal <punit.agrawal@arm.com> - 2015-09-14 15:20 +0200
Re: [Patch v3 4/5] hwmon: Support registration of thermal zones for SCP temperature sensors Punit Agrawal <punit.agrawal@arm.com> - 2015-09-14 15:20 +0200
csiph-web