Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1222989

Re: [PATCH 3/4] crypto: [sha] glue code for Intel SHA extensions optimized SHA1 & SHA256

Show all headers | View raw

Am Donnerstag, 10. September 2015, 17:04:31 schrieb Tim Chen:

Hi Tim,
>
>Is there a scenario you can think of
>when a lower performing sha1 transform needs to
>be exposed as a separate driver?

My immediate concern is testing: it is hard to test the individual 
implementations.
>
>Otherwise the glue code logic will only expose the
>best performing one for a cpu and hide the others, which was intentional
>on our part to prevent a lower performing sha from getting used.

Agreed, but the kernel crypto API does that already using the priorities -- 
IMHO a very clean and easy to interpret solution.

Furthermore, if somebody really has a need to not use the fastest HW 
implementation, the kernel crypto API allows him to do that. With the hard-
wired approach in the glue file, you are stuck.


Ciao
Stephan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 3/4] crypto: [sha] glue code for Intel SHA extensions  optimized SHA1 & SHA256 Tim Chen <tim.c.chen@linux.intel.com> - 2015-09-11 00:30 +0200
  Re: [PATCH 3/4] crypto: [sha] glue code for Intel SHA extensions optimized SHA1 & SHA256 Stephan Mueller <smueller@chronox.de> - 2015-09-11 01:00 +0200
    Re: [PATCH 3/4] crypto: [sha] glue code for Intel SHA extensions  optimized SHA1 & SHA256 Tim Chen <tim.c.chen@linux.intel.com> - 2015-09-11 02:10 +0200
      Re: [PATCH 3/4] crypto: [sha] glue code for Intel SHA extensions optimized SHA1 & SHA256 Stephan Mueller <smueller@chronox.de> - 2015-09-11 19:10 +0200
        Re: [PATCH 3/4] crypto: [sha] glue code for Intel SHA extensions  optimized SHA1 & SHA256 Tim Chen <tim.c.chen@linux.intel.com> - 2015-09-11 20:50 +0200
          Re: [PATCH 3/4] crypto: [sha] glue code for Intel SHA extensions optimized SHA1 & SHA256 Stephan Mueller <smueller@chronox.de> - 2015-09-11 21:20 +0200
          Re: [PATCH 3/4] crypto: [sha] glue code for Intel SHA extensions  optimized SHA1 & SHA256 David Miller <davem@davemloft.net> - 2015-09-11 21:20 +0200
            Re: [PATCH 3/4] crypto: [sha] glue code for Intel SHA extensions  optimized SHA1 & SHA256 Tim Chen <tim.c.chen@linux.intel.com> - 2015-09-11 22:20 +0200
              Re: [PATCH 3/4] crypto: [sha] glue code for Intel SHA extensions  optimized SHA1 & SHA256 Herbert Xu <herbert@gondor.apana.org.au> - 2015-09-12 10:20 +0200

csiph-web