Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1222426

Re: [PATCH 3/4] crypto: [sha] glue code for Intel SHA extensions optimized SHA1 & SHA256

Show all headers | View raw

Am Donnerstag, 10. September 2015, 15:27:20 schrieb Tim Chen:

Hi Tim,

>This patch adds the glue code to detect and utilize the Intel SHA
>extensions optimized SHA1 and SHA256 update transforms when available.
>
>This code has been tested on Broxton for functionality.

A general comment on this file: shouldn't this file be cleaned and use the 
standard mechanisms of the kernel crypto API?

This glue implements its own selection of which SHA implementation to use. But 
the kernel crypto API implements that logic already. The issue with the 
current implementation in this file is that you have no clue which particular 
implementation of SHA is in use in one particular case.

So, may I suggest a restructuring to define independent instances of SHA, such 
as

- cra_name == "sha1", cra_driver_name="sha1_ssse3", cra_priority=300
- cra_name == "sha1", cra_driver_name="sha1_avx", cra_priority=400
- cra_name == "sha1", cra_driver_name="sha1_avx2", cra_priority=500
- cra_name == "sha1", cra_driver_name="sha1_shavx", cra_priority=600

Similarly for the other SHAs?

In all the register functions for the ciphers, you can bail out if the 
hardware does not support an implementation.

Ciao
Stephan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 3/4] crypto: [sha] glue code for Intel SHA extensions  optimized SHA1 & SHA256 Tim Chen <tim.c.chen@linux.intel.com> - 2015-09-11 00:30 +0200
  Re: [PATCH 3/4] crypto: [sha] glue code for Intel SHA extensions optimized SHA1 & SHA256 Stephan Mueller <smueller@chronox.de> - 2015-09-11 01:00 +0200
    Re: [PATCH 3/4] crypto: [sha] glue code for Intel SHA extensions  optimized SHA1 & SHA256 Tim Chen <tim.c.chen@linux.intel.com> - 2015-09-11 02:10 +0200
      Re: [PATCH 3/4] crypto: [sha] glue code for Intel SHA extensions optimized SHA1 & SHA256 Stephan Mueller <smueller@chronox.de> - 2015-09-11 19:10 +0200
        Re: [PATCH 3/4] crypto: [sha] glue code for Intel SHA extensions  optimized SHA1 & SHA256 Tim Chen <tim.c.chen@linux.intel.com> - 2015-09-11 20:50 +0200
          Re: [PATCH 3/4] crypto: [sha] glue code for Intel SHA extensions optimized SHA1 & SHA256 Stephan Mueller <smueller@chronox.de> - 2015-09-11 21:20 +0200
          Re: [PATCH 3/4] crypto: [sha] glue code for Intel SHA extensions  optimized SHA1 & SHA256 David Miller <davem@davemloft.net> - 2015-09-11 21:20 +0200
            Re: [PATCH 3/4] crypto: [sha] glue code for Intel SHA extensions  optimized SHA1 & SHA256 Tim Chen <tim.c.chen@linux.intel.com> - 2015-09-11 22:20 +0200
              Re: [PATCH 3/4] crypto: [sha] glue code for Intel SHA extensions  optimized SHA1 & SHA256 Herbert Xu <herbert@gondor.apana.org.au> - 2015-09-12 10:20 +0200

csiph-web