Re: [PATCH] ARM: exynos_defconfig: Disable simplefb support

From	Michael Turquette <mturquette@baylibre.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] ARM: exynos_defconfig: Disable simplefb support
Date	2015-09-11 17:30 +0200
Message-ID	<q7yr0-5BA-25@gated-at.bofh.it> (permalink)
References	<q7aoF-31n-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Quoting Javier Martinez Canillas (2015-09-10 06:42:32)
> The simplefb driver allows the kernel to render on a pre-allocated
> buffer that's been initialized by firmware before the kernel boots.
> 
> This option was enabled to have display working on the Exynos5250
> Snow Chromebook by commit da9d0fbf5e9a ("ARM: exynos: defconfig
> update") since proper DRM/KMS support did not exist at that time.
> 
> But now that the Exynos DRM driver has support for this hardware,
> there is no need to have simplefb enabled. In fact, if a user has
> a u-boot that injects the simplefb dev node to the FDT before pass
> it to the kernel, display won't be properly initialized and only a
> blank screen will be shown since there isn't a proper handoff from
> the simplefb driver to the Exynos DRM driver.
> 
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>

Reviewed-by/Tested-by: Michael Turquette <mturquette@baylibre.com>

Thanks, this resolved one of the issues I had with U-boot that injected
the simplefb node.

Regards,
Mike

> 
> ---
> 
>  arch/arm/configs/exynos_defconfig | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/arch/arm/configs/exynos_defconfig b/arch/arm/configs/exynos_defconfig
> index 62f677f76a0b..20d878c83193 100644
> --- a/arch/arm/configs/exynos_defconfig
> +++ b/arch/arm/configs/exynos_defconfig
> @@ -139,7 +139,6 @@ CONFIG_DRM_EXYNOS_DSI=y
>  CONFIG_DRM_EXYNOS_HDMI=y
>  CONFIG_DRM_PANEL_SIMPLE=y
>  CONFIG_DRM_PANEL_SAMSUNG_S6E8AA0=y
> -CONFIG_FB_SIMPLE=y
>  CONFIG_EXYNOS_VIDEO=y
>  CONFIG_EXYNOS_MIPI_DSI=y
>  CONFIG_LCD_CLASS_DEVICE=y
> -- 
> 2.4.3
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] ARM: exynos_defconfig: Disable simplefb support Javier Martinez Canillas <javier@osg.samsung.com> - 2015-09-10 15:50 +0200
  Re: [PATCH] ARM: exynos_defconfig: Disable simplefb support Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-09-11 07:10 +0200
    Re: [PATCH] ARM: exynos_defconfig: Disable simplefb support Javier Martinez Canillas <javier@osg.samsung.com> - 2015-09-11 09:10 +0200
      Re: [PATCH] ARM: exynos_defconfig: Disable simplefb support Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-09-11 09:20 +0200
        Re: [PATCH] ARM: exynos_defconfig: Disable simplefb support Javier Martinez Canillas <javier@osg.samsung.com> - 2015-09-11 09:50 +0200
  Re: [PATCH] ARM: exynos_defconfig: Disable simplefb support Michael Turquette <mturquette@baylibre.com> - 2015-09-11 17:30 +0200

csiph-web