Re: [PATCH v2 1/5] ACPI: add in a bad_madt_entry() function to eventually replace the macro

Path	csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod
From	Sudeep Holla <sudeep.holla@arm.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 1/5] ACPI: add in a bad_madt_entry() function to eventually replace the macro
Date	Fri, 11 Sep 2015 10:50:02 +0200
Message-ID	<q7sbU-4SS-9@gated-at.bofh.it> (permalink)
References	<pZjIu-27O-11@gated-at.bofh.it> <pZjIv-27O-33@gated-at.bofh.it> <q66Gu-1eb-21@gated-at.bofh.it> <q6THc-4vo-27@gated-at.bofh.it> <q7cTw-6MC-23@gated-at.bofh.it> <q7gX8-4c4-5@gated-at.bofh.it>
X-Original-To	Al Stone <ahs3@redhat.com>, Al Stone <al.stone@linaro.org>, "linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>
User-Agent	Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0
MIME-Version	1.0
Content-Type	text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding	7bit
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	46
Organization	linux.* mail to news gateway
X-Original-Cc	Sudeep Holla <sudeep.holla@arm.com>, "linaro-kernel@lists.linaro.org" <linaro-kernel@lists.linaro.org>, "linux-ia64@vger.kernel.org" <linux-ia64@vger.kernel.org>, "patches@linaro.org" <patches@linaro.org>, "linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>, "linaro-acpi@lists.linaro.org" <linaro-acpi@lists.linaro.org>, "Rafael J. Wysocki" <rjw@rjwysocki.net>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, Len Brown <lenb@kernel.org>
X-Original-Date	Fri, 11 Sep 2015 09:49:43 +0100
X-Original-Message-ID	<55F295A7.20406@arm.com>
X-Original-References	<1440022048-6285-1-git-send-email-al.stone@linaro.org> <1440022048-6285-2-git-send-email-al.stone@linaro.org> <55EDADF5.5060008@arm.com> <55F08F47.1070906@redhat.com> <55F1ADC4.7090005@arm.com> <55F1EB81.9030908@redhat.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1222631

Show key headers only | View raw


On 10/09/15 21:43, Al Stone wrote:
> On 09/10/2015 10:20 AM, Sudeep Holla wrote:
>>

[...]

>>
>>  From the code inspection, I can see we have 3 users of acpi_parse_entries not
>> just MADT but also PCC and NUMA/SRAT
>>
>> Something like this solves this issue:
>> -              if (bad_madt_entry(table_header, entry))
>> +              if (!strncmp(id, ACPI_SIG_MADT, 4) &&
>> +                      bad_madt_entry(table_header, entry)
>>
>>
>> Or am I still missing something ?
>
> Nope, I missed it.  Your fix above will solve the problem; I misunderstood
> how acpi_parse_entries() was being used -- somehow I had it in my head that
> only MADT was in use, and just not seeing that it's being used for several
> other subtable traversals also.  Sorry about that, Sudeep.  My mistake.
>

No worries.

> I'll add this fix for a v4, but I'll wait for a few days to see if I get any
> additional comments -- I haven't heard from any x86, ia64 or ACPI maintainers

Makes sense.

> yet.  OTOH, it's nice to know we've already found and fixed two sets of arm64
> ACPI tables that are in error by using these patches, even with the flaws :).
>

Very much true indeed :)

Regards,
Sudeep
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v2 1/5] ACPI: add in a bad_madt_entry() function to eventually  replace the macro Sudeep Holla <sudeep.holla@arm.com> - 2015-09-07 17:40 +0200
  Re: [PATCH v2 1/5] ACPI: add in a bad_madt_entry() function to  eventually replace the macro Al Stone <ahs3@redhat.com> - 2015-09-09 01:10 +0200
  Re: [PATCH v2 1/5] ACPI: add in a bad_madt_entry() function to  eventually replace the macro Al Stone <ahs3@redhat.com> - 2015-09-09 22:00 +0200
    Re: [PATCH v2 1/5] ACPI: add in a bad_madt_entry() function to  eventually replace the macro Sudeep Holla <sudeep.holla@arm.com> - 2015-09-10 18:30 +0200
      Re: [PATCH v2 1/5] ACPI: add in a bad_madt_entry() function to  eventually replace the macro Al Stone <ahs3@redhat.com> - 2015-09-10 22:50 +0200
        Re: [PATCH v2 1/5] ACPI: add in a bad_madt_entry() function to  eventually replace the macro Sudeep Holla <sudeep.holla@arm.com> - 2015-09-11 10:50 +0200

csiph-web