Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1220271

Re: [PATCH v2 1/5] ACPI: add in a bad_madt_entry() function to eventually replace the macro

Show all headers | View raw

Hi Al,

On 19/08/15 23:07, Al Stone wrote:

I finally got a chance to try this series on Juno. Well it exposed a 
firmware bug in MADT table :)

[..]

>                  acpi_tbl_entry_handler handler,
> @@ -245,6 +484,8 @@ acpi_parse_entries(char *id, unsigned long table_size,
>                 table_end) {
>                  if (entry->type == entry_id
>                      && (!max_entries || count < max_entries)) {
> +                       if (bad_madt_entry(table_header, entry))
> +                               return -EINVAL;

Not sure if we can have the above check here unconditionally.
Currently I can see there are 2 other users of acpi_parse_entries i.e.
PCC and NUMA. So may be it can be made conditional or return success for
non-MADT tables from bad_madt_entry ?

Other than that, you can add for ARM64 specific parts:
Reviewed-and-tested-by: Sudeep Holla <sudeep.holla@arm.com>

Regards,
Sudeep
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 0/5] ACPI: Provide better MADT subtable sanity checks Al Stone <al.stone@linaro.org> - 2015-08-20 00:10 +0200
  [PATCH v2 3/5] ACPI / IA64: remove usage of BAD_MADT_ENTRY Al Stone <al.stone@linaro.org> - 2015-08-20 00:10 +0200
  [PATCH v2 2/5] ACPI / ARM64: remove usage of BAD_MADT_ENTRY/BAD_MADT_GICC_ENTRY Al Stone <al.stone@linaro.org> - 2015-08-20 00:10 +0200
    Re: [PATCH v2 2/5] ACPI / ARM64: remove usage of  BAD_MADT_ENTRY/BAD_MADT_GICC_ENTRY Will Deacon <will.deacon@arm.com> - 2015-08-20 12:20 +0200
      Re: [PATCH v2 2/5] ACPI / ARM64: remove usage of  BAD_MADT_ENTRY/BAD_MADT_GICC_ENTRY Al Stone <ahs3@redhat.com> - 2015-08-20 19:00 +0200
        Re: [PATCH v2 2/5] ACPI / ARM64: remove usage of  BAD_MADT_ENTRY/BAD_MADT_GICC_ENTRY Will Deacon <will.deacon@arm.com> - 2015-08-24 12:10 +0200
  [PATCH v2 1/5] ACPI: add in a bad_madt_entry() function to eventually replace the macro Al Stone <al.stone@linaro.org> - 2015-08-20 00:10 +0200
    Re: [PATCH v2 1/5] ACPI: add in a bad_madt_entry() function to  eventually replace the macro Timur Tabi <timur@codeaurora.org> - 2015-08-26 17:40 +0200
      Re: [PATCH v2 1/5] ACPI: add in a bad_madt_entry() function to  eventually replace the macro Al Stone <ahs3@redhat.com> - 2015-08-26 22:40 +0200
    Re: [PATCH v2 1/5] ACPI: add in a bad_madt_entry() function to eventually  replace the macro Sudeep Holla <sudeep.holla@arm.com> - 2015-09-07 17:40 +0200
      Re: [PATCH v2 1/5] ACPI: add in a bad_madt_entry() function to  eventually replace the macro Al Stone <ahs3@redhat.com> - 2015-09-09 01:10 +0200
      Re: [PATCH v2 1/5] ACPI: add in a bad_madt_entry() function to  eventually replace the macro Al Stone <ahs3@redhat.com> - 2015-09-09 22:00 +0200
        Re: [PATCH v2 1/5] ACPI: add in a bad_madt_entry() function to  eventually replace the macro Sudeep Holla <sudeep.holla@arm.com> - 2015-09-10 18:30 +0200
          Re: [PATCH v2 1/5] ACPI: add in a bad_madt_entry() function to  eventually replace the macro Al Stone <ahs3@redhat.com> - 2015-09-10 22:50 +0200
            Re: [PATCH v2 1/5] ACPI: add in a bad_madt_entry() function to  eventually replace the macro Sudeep Holla <sudeep.holla@arm.com> - 2015-09-11 10:50 +0200

csiph-web