Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1223321
| Path | csiph.com!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod |
|---|---|
| From | Julia Lawall <julia.lawall@lip6.fr> |
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 4/4] Staging: vt6656: Bool tests don't need comparisons |
| Date | Sat, 12 Sep 2015 08:20:02 +0200 |
| Message-ID | <q7Mki-Cv-7@gated-at.bofh.it> (permalink) |
| References | <q7M0W-8sn-1@gated-at.bofh.it> <q7M0W-8sn-11@gated-at.bofh.it> |
| X-Original-To | Shraddha Barke <shraddha.6596@gmail.com> |
| X-Ironport-Av | E=Sophos;i="5.17,516,1437429600"; d="scan'208";a="177093760" |
| X-X-Sender | jll@localhost6.localdomain6 |
| User-Agent | Alpine 2.02 (DEB 1266 2009-07-14) |
| MIME-Version | 1.0 |
| Content-Type | TEXT/PLAIN; charset=US-ASCII |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 40 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Jes Sorensen <Jes.Sorensen@redhat.com>, linux-kernel@vger.kernel.org |
| X-Original-Date | Sat, 12 Sep 2015 08:10:46 +0200 (CEST) |
| X-Original-Message-ID | <alpine.DEB.2.02.1509120809590.2051@localhost6.localdomain6> |
| X-Original-References | <1442037000-2953-1-git-send-email-shraddha.6596@gmail.com> <1442037000-2953-4-git-send-email-shraddha.6596@gmail.com> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1223321 |
Show key headers only | View raw
On Sat, 12 Sep 2015, Shraddha Barke wrote: > This patch removes comparisons to true/false values on bool variables. > Fix made using Coccinelle > > Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com> > --- > drivers/staging/vt6656/wcmd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/vt6656/wcmd.c b/drivers/staging/vt6656/wcmd.c > index 3cbf479..ab7401e 100644 > --- a/drivers/staging/vt6656/wcmd.c > +++ b/drivers/staging/vt6656/wcmd.c > @@ -177,7 +177,7 @@ int vnt_schedule_command(struct vnt_private *priv, enum vnt_cmd command) > ADD_ONE_WITH_WRAP_AROUND(priv->cmd_enqueue_idx, CMD_Q_SIZE); > priv->free_cmd_queue--; > > - if (priv->cmd_running == false) > + if (priv->cmd_running) You turned it into a test for true. It seems strange that this would happen if you used a rule. julia > vnt_cmd_complete(priv); > > return true; > -- > 2.1.4 > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 1/4] Staging: rtl8723au: Bool tests don't need comparisons Shraddha Barke <shraddha.6596@gmail.com> - 2015-09-12 08:00 +0200
[PATCH 3/4] Staging: rtl8712: Bool tests don't need comparisons Shraddha Barke <shraddha.6596@gmail.com> - 2015-09-12 08:00 +0200
[PATCH 2/4] Staging: rtl8188eu: Bool tests don't need comparisons Shraddha Barke <shraddha.6596@gmail.com> - 2015-09-12 08:00 +0200
[PATCH 4/4] Staging: vt6656: Bool tests don't need comparisons Shraddha Barke <shraddha.6596@gmail.com> - 2015-09-12 08:00 +0200
Re: [PATCH 4/4] Staging: vt6656: Bool tests don't need comparisons Julia Lawall <julia.lawall@lip6.fr> - 2015-09-12 08:20 +0200
Re: [PATCH 1/4] Staging: rtl8723au: Bool tests don't need comparisons Joe Perches <joe@perches.com> - 2015-09-12 08:30 +0200
csiph-web