Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1223115

Re: [PATCH 1/3] doc: dt: add documentation for Mediatek spi-nor controller

Show all headers | View raw

One more thing:

On Tue, Sep 08, 2015 at 05:49:54PM +0800, Bayi Cheng wrote:
> +- clocks: spi nor source clock

^^ you only list one clock here

> +- clock-names: "spi_clk", "axi_clk", "mux_clk", "sf_clk"

But you have 4 names here.

...
> +	clocks = <&pericfg CLK_PERI_SPI>,
> +		 <&topckgen CLK_TOP_AXI_SEL>,
> +		 <&topckgen CLK_TOP_UNIVPLL2_D8>,
> +		 <&topckgen CLK_TOP_SPINFI_IFR_SEL>;

And you provide 4 clocks.

> +	clock-names = "spi_clk", "axi_clk", "mux_clk", "sf_clk";

Please list all 4 under the "clocks" property, not just under the
"clock-names" property.

Brian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/3] Mediatek SPI-NOR flash driver  Bayi Cheng <bayi.cheng@mediatek.com> - 2015-09-08 12:00 +0200
  [PATCH 1/3] doc: dt: add documentation for Mediatek spi-nor controller Bayi Cheng <bayi.cheng@mediatek.com> - 2015-09-08 12:00 +0200
    Re: [PATCH 1/3] doc: dt: add documentation for Mediatek spi-nor controller Jagan Teki <jteki@openedev.com> - 2015-09-08 13:40 +0200
    Re: [PATCH 1/3] doc: dt: add documentation for Mediatek spi-nor  controller Sascha Hauer <s.hauer@pengutronix.de> - 2015-09-09 07:50 +0200
    Re: [PATCH 1/3] doc: dt: add documentation for Mediatek spi-nor  controller Brian Norris <computersforpeace@gmail.com> - 2015-09-11 23:50 +0200
    Re: [PATCH 1/3] doc: dt: add documentation for Mediatek spi-nor  controller Brian Norris <computersforpeace@gmail.com> - 2015-09-11 23:50 +0200
  [PATCH 2/3] mtd: mtk-nor: mtk serial flash controller driver Bayi Cheng <bayi.cheng@mediatek.com> - 2015-09-08 12:00 +0200
    Re: [PATCH 2/3] mtd: mtk-nor: mtk serial flash controller driver Sascha Hauer <s.hauer@pengutronix.de> - 2015-09-09 08:40 +0200
      Re: [PATCH 2/3] mtd: mtk-nor: mtk serial flash controller driver Lothar Waßmann <LW@KARO-electronics.de> - 2015-09-09 15:10 +0200
  [PATCH 3/3] arm64: dts: mt8173: Add nor flash node Bayi Cheng <bayi.cheng@mediatek.com> - 2015-09-08 12:00 +0200
    Re: [PATCH 3/3] arm64: dts: mt8173: Add nor flash node Jagan Teki <jteki@openedev.com> - 2015-09-08 14:00 +0200
      Re: [PATCH 3/3] arm64: dts: mt8173: Add nor flash node Ezequiel Garcia <ezequiel@vanguardiasur.com.ar> - 2015-09-08 17:20 +0200
        Re: [PATCH 3/3] arm64: dts: mt8173: Add nor flash node Rob Herring <robh@kernel.org> - 2015-09-09 07:40 +0200
          Re: [PATCH 3/3] arm64: dts: mt8173: Add nor flash node Brian Norris <computersforpeace@gmail.com> - 2015-09-12 00:00 +0200

csiph-web