Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1221817
| From | Viresh Kumar <viresh.kumar@linaro.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 1/7] cpufreq: remove redundant CPUFREQ_INCOMPATIBLE notifier event |
| Date | 2015-09-10 02:40 +0200 |
| Message-ID | <q6Y49-2nB-1@gated-at.bofh.it> (permalink) |
| References | <pTeit-6ZV-5@gated-at.bofh.it> <pTeiu-6ZV-13@gated-at.bofh.it> <q6Wvn-8wd-1@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 10-09-15, 01:26, Rafael J. Wysocki wrote: > On Monday, August 03, 2015 08:36:14 AM Viresh Kumar wrote: > > What's being done from CPUFREQ_INCOMPATIBLE, can also be done with > > CPUFREQ_ADJUST. There is nothing special with CPUFREQ_INCOMPATIBLE > > notifier. > > The above part of the changelog is a disaster to me. :-( > > It not only doesn't explain what really goes on, but it's actively confusing. > > What really happens is that the core sends CPUFREQ_INCOMPATIBLE notifications > unconditionally right after sending the CPUFREQ_ADJUST ones, so the former is > just redundant and it's more efficient to merge the two into one. Undoubtedly this looks far better :) But, isn't this series already applied some time back ? > > Kill CPUFREQ_INCOMPATIBLE and fix its usage sites. > > > > This also updates the numbering of notifier events to remove holes. > > Why don't you redefine CPUFREQ_ADJUST as 1 instead? So that there is no request with 0? Yeah that could have been done. -- viresh -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Re: [PATCH 1/7] cpufreq: remove redundant CPUFREQ_INCOMPATIBLE notifier event "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2015-09-10 01:00 +0200
Re: [PATCH 1/7] cpufreq: remove redundant CPUFREQ_INCOMPATIBLE notifier event Viresh Kumar <viresh.kumar@linaro.org> - 2015-09-10 02:40 +0200
Re: [PATCH 1/7] cpufreq: remove redundant CPUFREQ_INCOMPATIBLE notifier event "Rafael J. Wysocki" <rafael@kernel.org> - 2015-09-10 03:00 +0200
csiph-web