Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1221816

Re: [PATCH 0/3] serial: samsung: Fix UART status handling and other fixes

Show all headers | View raw

On 09.09.2015 18:15, Robert Baldyga wrote:
> On 09/09/2015 01:47 AM, Krzysztof Kozlowski wrote:
>> On 08.09.2015 18:38, Robert Baldyga wrote:
>>> Hello,
>>>
>>> This patch set contains three patches: two minor fixes and one quite
>>> important bugfix enabling UART status handling in DMA mode, which was
>>> missing so far. It enables, among others, 'break' contition handling,
>>> which is necessary if we want to use Magic SysRq. So this patch fixes
>>> Magic SysRq handling for serial consoles using UART in DMA mode,
>>
>> Is it even worth using UART for serial console in DMA mode? How many
>> benefits it brings? Anyone measured real data?
>>
>> The patch which enabled DMA for all serial ports on Exynos4 uncovered
>> some issues. That is one benefit... but was it worth it?
> 
> Well, UART in DMA mode should work at least as good as in PIO, so there
> is nothing wrong in having serial console configured in DMA. Sure, it
> rather barely reduces number of interrupts while used as typical serial
> console, but in some cases (eg. using zmodem) it can be more profitable.

That's some reason... and mentioned earlier testing of DMA which
uncovered some interesting issues. :)

> 
> To be honest, I have no strong feeling about that. I've decided to
> utilize new possibility opened by introducing DMA mode in serial driver,
> so I've send patch enabling it for each port on Exynos4. But if it
> turned out to be unneeded I will not insist on it.

I was just thinking loud... I don't have any data neither so let's go
ahead with serial DMA.

Best regards,
Krzysztof
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 0/3] serial: samsung: Fix UART status handling and other fixes Robert Baldyga <r.baldyga@samsung.com> - 2015-09-08 11:40 +0200
  [PATCH 1/3] serial: samsung: remove unused 'irq' parameter Robert Baldyga <r.baldyga@samsung.com> - 2015-09-08 11:40 +0200
    Re: [PATCH 1/3] serial: samsung: remove unused 'irq' parameter Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-09-10 02:30 +0200
  [PATCH 3/3] serial: samsung: Fix UART status handling in DMA mode Robert Baldyga <r.baldyga@samsung.com> - 2015-09-08 11:40 +0200
    Re: [PATCH 3/3] serial: samsung: Fix UART status handling in DMA mode Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-09-10 02:50 +0200
      Re: [PATCH 3/3] serial: samsung: Fix UART status handling in DMA mode Robert Baldyga <r.baldyga@samsung.com> - 2015-09-10 12:50 +0200
  [PATCH 2/3] serial: samsung: remove unneded 'ignore_char' label Robert Baldyga <r.baldyga@samsung.com> - 2015-09-08 11:50 +0200
    Re: [PATCH 2/3] serial: samsung: remove unneded 'ignore_char' label Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-09-10 02:30 +0200
      Re: [PATCH 2/3] serial: samsung: remove unneded 'ignore_char' label Robert Baldyga <r.baldyga@samsung.com> - 2015-09-10 12:40 +0200
  Re: [PATCH 0/3] serial: samsung: Fix UART status handling and other  fixes Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-09-09 01:50 +0200
    Re: [PATCH 0/3] serial: samsung: Fix UART status handling and other  fixes Robert Baldyga <r.baldyga@samsung.com> - 2015-09-09 11:20 +0200
      Re: [PATCH 0/3] serial: samsung: Fix UART status handling and other  fixes Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-09-10 02:30 +0200

csiph-web