Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1213969

Re: [PATCH v2 1/5] ACPI: add in a bad_madt_entry() function to eventually replace the macro

Show all headers | View raw

On Wed, Aug 19, 2015 at 5:07 PM, Al Stone <al.stone@linaro.org> wrote:
> +                               pr_err("Variable length MADT subtable %d is wrong size: %d\n",
> +                                      entry->type, entry->length);
> +                               return 1;
> +                       }
> +               }
> +       } else {
> +               if (entry->length != len) {
> +                       pr_err("MADT subtable %d is wrong size: %d\n",
> +                              len, entry->type);

Can we make these a little more descriptive?

pr_err("Variable length MADT subtable type %d is wrong size: %d,
should be %d\n",
      entry->type, entry->length, len);

pr_err("MADT subtable type %d is wrong size: %d, should be %d\n",
      entry->type, entry->length, len);




-- 
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 0/5] ACPI: Provide better MADT subtable sanity checks Al Stone <al.stone@linaro.org> - 2015-08-20 00:10 +0200
  [PATCH v2 3/5] ACPI / IA64: remove usage of BAD_MADT_ENTRY Al Stone <al.stone@linaro.org> - 2015-08-20 00:10 +0200
  [PATCH v2 2/5] ACPI / ARM64: remove usage of BAD_MADT_ENTRY/BAD_MADT_GICC_ENTRY Al Stone <al.stone@linaro.org> - 2015-08-20 00:10 +0200
    Re: [PATCH v2 2/5] ACPI / ARM64: remove usage of  BAD_MADT_ENTRY/BAD_MADT_GICC_ENTRY Will Deacon <will.deacon@arm.com> - 2015-08-20 12:20 +0200
      Re: [PATCH v2 2/5] ACPI / ARM64: remove usage of  BAD_MADT_ENTRY/BAD_MADT_GICC_ENTRY Al Stone <ahs3@redhat.com> - 2015-08-20 19:00 +0200
        Re: [PATCH v2 2/5] ACPI / ARM64: remove usage of  BAD_MADT_ENTRY/BAD_MADT_GICC_ENTRY Will Deacon <will.deacon@arm.com> - 2015-08-24 12:10 +0200
  [PATCH v2 1/5] ACPI: add in a bad_madt_entry() function to eventually replace the macro Al Stone <al.stone@linaro.org> - 2015-08-20 00:10 +0200
    Re: [PATCH v2 1/5] ACPI: add in a bad_madt_entry() function to  eventually replace the macro Timur Tabi <timur@codeaurora.org> - 2015-08-26 17:40 +0200
      Re: [PATCH v2 1/5] ACPI: add in a bad_madt_entry() function to  eventually replace the macro Al Stone <ahs3@redhat.com> - 2015-08-26 22:40 +0200

csiph-web