Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1220088

Re: [PATCH 2/6] perf, tools, stat: Abstract stat metrics printing

From Jiri Olsa <jolsa@redhat.com>
Newsgroups linux.kernel
Subject Re: [PATCH 2/6] perf, tools, stat: Abstract stat metrics printing
Date 2015-09-07 13:50 +0200
Message-ID <q635T-4u5-1@gated-at.bofh.it> (permalink)
References <q57XY-7hG-3@gated-at.bofh.it> <q57XZ-7hG-33@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Fri, Sep 04, 2015 at 03:45:13PM -0700, Andi Kleen wrote:

SNIP

> @@ -695,11 +743,7 @@ static void print_counter_aggr(struct perf_evsel *counter, char *prefix)
>  	}
>  
>  	uval = avg * counter->scale;
> -
> -	if (nsec_counter(counter))
> -		nsec_printout(-1, 0, counter, uval);
> -	else
> -		abs_printout(-1, 0, counter, uval);
> +	printout(-1, 0, counter, uval);
>  
>  	print_noise(counter, avg);
>  
> @@ -752,15 +796,9 @@ static void print_counter(struct perf_evsel *counter, char *prefix)
>  		}
>  
>  		uval = val * counter->scale;
> -
> -		if (nsec_counter(counter))
> -			nsec_printout(cpu, 0, counter, uval);
> -		else
> -			abs_printout(cpu, 0, counter, uval);
> -
> +		printout(cpu, 0, counter, uval);
>  		if (!csv_output)
>  			print_noise(counter, 1.0);
> -		print_running(run, ena);

why is this one removed?

jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

perf, tools: Refactor and support interval and CSV metrics v4 Andi Kleen <andi@firstfloor.org> - 2015-09-05 00:50 +0200
  [PATCH 3/6] perf, tools, stat: Add support for metrics in interval mode Andi Kleen <andi@firstfloor.org> - 2015-09-05 00:50 +0200
  [PATCH 6/6] perf, tools, stat: Move non counting counter printing to printout Andi Kleen <andi@firstfloor.org> - 2015-09-05 00:50 +0200
  [PATCH 5/6] perf, tools, stat: Implement CSV metrics output Andi Kleen <andi@firstfloor.org> - 2015-09-05 00:50 +0200
  [PATCH 2/6] perf, tools, stat: Abstract stat metrics printing Andi Kleen <andi@firstfloor.org> - 2015-09-05 00:50 +0200
    Re: [PATCH 2/6] perf, tools, stat: Abstract stat metrics printing Jiri Olsa <jolsa@redhat.com> - 2015-09-07 13:50 +0200
    Re: [PATCH 2/6] perf, tools, stat: Abstract stat metrics printing Jiri Olsa <jolsa@redhat.com> - 2015-09-07 14:20 +0200
      Re: [PATCH 2/6] perf, tools, stat: Abstract stat metrics printing Andi Kleen <ak@linux.intel.com> - 2015-09-08 18:10 +0200
        Re: [PATCH 2/6] perf, tools, stat: Abstract stat metrics printing Jiri Olsa <jolsa@redhat.com> - 2015-09-08 18:30 +0200

csiph-web