Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1220950

Re: [PATCH 2/6] perf, tools, stat: Abstract stat metrics printing

From Andi Kleen <ak@linux.intel.com>
Newsgroups linux.kernel
Subject Re: [PATCH 2/6] perf, tools, stat: Abstract stat metrics printing
Date 2015-09-08 18:10 +0200
Message-ID <q6tD4-K0-13@gated-at.bofh.it> (permalink)
References <q57XY-7hG-3@gated-at.bofh.it> <q57XZ-7hG-33@gated-at.bofh.it> <q63yV-5hl-5@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


>   - introduce the print_metrics interface for perf_stat__print_shadow_stats
>   - introduce printout function
>   - introduce support for printing metrics in csv in interval mode

That's already a separate patch.

>   - and enable i
> 
> 
> or any other way you find feasible *easy to review*.. I cannot ack it at this state

Well it's just printing out values. It's really not rocket science. Nobody
is asking you to review a new VM subsystems or something like that.

I expect each more "refactoring" to add more problems. It's just really hard to to do,
and usually adds more problems.

I can try one more time, but if it doesn't work out we'll have to give up on this.

-Andi

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

Re: [PATCH 2/6] perf, tools, stat: Abstract stat metrics printing Jiri Olsa <jolsa@redhat.com> - 2015-09-07 14:20 +0200
  Re: [PATCH 2/6] perf, tools, stat: Abstract stat metrics printing Andi Kleen <ak@linux.intel.com> - 2015-09-08 18:10 +0200
    Re: [PATCH 2/6] perf, tools, stat: Abstract stat metrics printing Jiri Olsa <jolsa@redhat.com> - 2015-09-08 18:30 +0200

csiph-web